alexcrichton requested wasmtime-default-reviewers for a review on PR #12867.
alexcrichton opened PR #12867 from alexcrichton:pulley-opcode-max to bytecodealliance:main:
This was off-by-one which could lead to possible undefined behavior in Miri and at runtime when disassembling invalid opcodes. This isn't reachable from Wasmtime itself since Cranelift only generates valid opcodes, but it's nonetheless reachable via
wasmtime objdumpand still good to fix.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested rvolosatovs for a review on PR #12867.
alexcrichton edited PR #12867:
This was off-by-one which could lead to possible undefined behavior in Miri and at runtime when disassembling invalid opcodes. This isn't reachable from Wasmtime itself since Cranelift only generates valid opcodes, but it's nonetheless reachable via
wasmtime objdumpand still good to fix.Closes #12813
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
github-actions[bot] added the label pulley on PR #12867.
github-actions[bot] commented on PR #12867:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "pulley"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen submitted PR review.
fitzgen added PR #12867 Fix ExtendedOpcode::MAX for Pulley to the merge queue.
fitzgen merged PR #12867.
fitzgen removed PR #12867 Fix ExtendedOpcode::MAX for Pulley from the merge queue.
Last updated: Apr 13 2026 at 00:25 UTC