Stream: git-wasmtime

Topic: wasmtime / PR #12858 Handle OOM in the rest of Wasmtime's...

Wasmtime GitHub notifications bot (Mar 27 2026 at 19:26):

fitzgen opened PR #12858 from fitzgen:more-oom-handling to bytecodealliance:main:

See commits for details.

Wasmtime GitHub notifications bot (Mar 27 2026 at 19:26):

fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12858.

Wasmtime GitHub notifications bot (Mar 27 2026 at 19:26):

fitzgen requested dicej for a review on PR #12858.

Wasmtime GitHub notifications bot (Mar 27 2026 at 19:26):

fitzgen requested wasmtime-core-reviewers for a review on PR #12858.

Wasmtime GitHub notifications bot (Mar 27 2026 at 19:39):

fitzgen updated PR #12858.

Wasmtime GitHub notifications bot (Mar 27 2026 at 22:54):

github-actions[bot] added the label fuzzing on PR #12858.

Wasmtime GitHub notifications bot (Mar 27 2026 at 22:54):

github-actions[bot] added the label wasmtime:api on PR #12858.

Wasmtime GitHub notifications bot (Mar 27 2026 at 22:54):

github-actions[bot] commented on PR #12858:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 30 2026 at 12:54):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 30 2026 at 12:54):

alexcrichton created PR review comment:

s/expect/panic_on_oom/

Wasmtime GitHub notifications bot (Mar 30 2026 at 12:54):

alexcrichton created PR review comment:

How come this has a map_err?

Wasmtime GitHub notifications bot (Mar 30 2026 at 12:54):

alexcrichton created PR review comment:

s/expect/panic_on_oom/

Wasmtime GitHub notifications bot (Mar 30 2026 at 12:54):

alexcrichton created PR review comment:

This is kind of unfortunate given that the Vec here is just an "unfortunate implementation detail". Would you be up for reimplementing this differently to avoid the Vec altogether?

I think that should be possible through:

• &mut StoreOpaque => Pin<&mut vm::Instance>
• Pin<&mut vm::Instance> => &Module + Pin<&mut vm::Instance> with module_and_self
• vm::Instance::get_export_by_index_mut to get all the exports, iterators/borrows from &Module for iterating exports and such.

It'll require some unsafe since a StoreId needs to get passed in to get_export_by_index_mut but this is a pretty minor unsafe

Wasmtime GitHub notifications bot (Mar 30 2026 at 12:54):

alexcrichton created PR review comment:

WDYT about changing the signature here to return Result<Extern> to avoid needing to have a get and a try_get? This is a relatively minor method so returning Result seems reasonable to me (e.g. the cost of allocating an error on "not present"). Also same logic below for get_by_import and returning an error instead of an Option

Wasmtime GitHub notifications bot (Mar 30 2026 at 14:17):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 30 2026 at 14:17):

fitzgen created PR review comment:

Whoops, thought I caught all of those.

Wasmtime GitHub notifications bot (Mar 30 2026 at 15:18):

fitzgen updated PR #12858.

Wasmtime GitHub notifications bot (Mar 30 2026 at 15:18):

fitzgen has enabled auto merge for PR #12858.

Wasmtime GitHub notifications bot (Mar 30 2026 at 15:26):

fitzgen updated PR #12858.

Wasmtime GitHub notifications bot (Mar 30 2026 at 15:37):

fitzgen updated PR #12858.

Wasmtime GitHub notifications bot (Mar 30 2026 at 15:54):

fitzgen added PR #12858 Handle OOM in the rest of Wasmtime's non-component, -async, -compilation APIs to the merge queue.

Wasmtime GitHub notifications bot (Mar 30 2026 at 18:06):

alexcrichton commented on PR #12858:

Failed here. I think this may be fixed with a commit from https://github.com/bytecodealliance/wasmtime/pull/12869, https://github.com/bytecodealliance/wasmtime/pull/12869/changes/0570c46de7d93afb0e87e9e8d37b454d12aab35b. I'll re-queue this around that unless you want to add that commit here to resolve the failure.

Wasmtime GitHub notifications bot (Mar 30 2026 at 18:06):

alexcrichton removed PR #12858 Handle OOM in the rest of Wasmtime's non-component, -async, -compilation APIs from the merge queue.

Wasmtime GitHub notifications bot (Mar 30 2026 at 18:35):

alexcrichton added PR #12858 Handle OOM in the rest of Wasmtime's non-component, -async, -compilation APIs to the merge queue.

Wasmtime GitHub notifications bot (Mar 30 2026 at 20:12):

fitzgen commented on PR #12858:

I'll re-queue this around that

Thanks!

Wasmtime GitHub notifications bot (Mar 30 2026 at 21:19):

alexcrichton merged PR #12858.

Wasmtime GitHub notifications bot (Mar 30 2026 at 21:19):

alexcrichton removed PR #12858 Handle OOM in the rest of Wasmtime's non-component, -async, -compilation APIs from the merge queue.

Last updated: Apr 12 2026 at 23:10 UTC