Wasmtime GitHub notifications bot (Mar 11 2020 at 16:41): Wasmtime GitHub notifications bot (Mar 11 2020 at 16:41):noculture opened PR #1285 from tutorial-docs to master:
This PR adds a tutorial on creating and running
hello-world.wasmwith wasmtime to the docs.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 11 2020 at 17:12):noculture updated PR #1285 from tutorial-docs to master:
This PR adds a tutorial on creating and running
hello-world.wasmwith wasmtime to the docs.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 11 2020 at 18:14):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 11 2020 at 18:14):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 11 2020 at 18:14):alexcrichton created PR Review Comment:
Could this link to the documentation about how to install the CLI?
Could this section also be expanded with some words about how there's a number of ways to run wasmtime, and the CLI is only one example? This'd be a good spot to link to the other embeddings/languages too to showcase how to use wasmtime in other contexts.
Wasmtime GitHub notifications bot (Mar 11 2020 at 18:14):alexcrichton created PR Review Comment:
Could this include a bit of an intro which talks about how there's a number of ways to create wasm files, but for the purposes of this tutorial we're going to be using a Rust toolchain? This can also link to the other section of documentation which details how to build wasm from other languages.
Wasmtime GitHub notifications bot (Mar 11 2020 at 18:14):alexcrichton created PR Review Comment:
I think this syntax may not be what you want, instead of a
:I think you'll want to put the url in parens
Wasmtime GitHub notifications bot (Mar 11 2020 at 19:09):noculture updated PR #1285 from tutorial-docs to master:
This PR adds a tutorial on creating and running
hello-world.wasmwith wasmtime to the docs.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 11 2020 at 19:44):noculture requested alexcrichton for a review on PR #1285.
Wasmtime GitHub notifications bot (Mar 11 2020 at 19:55):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 11 2020 at 19:55):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 11 2020 at 19:55):alexcrichton created PR Review Comment:
Could this link directly to the CLI installation docs as well? I think it's alright to inline a few of them, but we want to make sure it's easy to get mor einformation about installing if necessary.
Wasmtime GitHub notifications bot (Mar 11 2020 at 19:55):alexcrichton created PR Review Comment:
Oh for inter-links in the book it's probably best to use
wasm.mdinstead of a full url towasm.html, that way local renders should still work.
Wasmtime GitHub notifications bot (Mar 12 2020 at 15:20):noculture updated PR #1285 from tutorial-docs to master:
This PR adds a tutorial on creating and running
hello-world.wasmwith wasmtime to the docs.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 12 2020 at 15:49):alexcrichton merged PR #1285.
Last updated: Nov 22 2024 at 16:03 UTC