marmistrz opened PR #1284 from path_symlink_follow
to master
:
Currently,
path_link
doesn't takeold_flags
into account and always follows symlinks. Besides, the tests are incorrect: it's okay to create a hardlink to the dangling symlink or a symlink loop as long as symlinks are not being followed.This PR fixes the tests and makes sure that
path_link
follows symlinks only when asked to.I've discovered this issue while working on the implementation of
path_link
for Windows and decided it's going to be easier to discuss the issue together with a fix.
marmistrz requested peterhuene, kubkon, and sunfishcode for a review on PR #1284.
marmistrz requested peterhuene, kubkon, and sunfishcode for a review on PR #1284.
marmistrz requested peterhuene, kubkon, and sunfishcode for a review on PR #1284.
marmistrz updated PR #1284 from path_symlink_follow
to master
:
Currently,
path_link
doesn't takeold_flags
into account and always follows symlinks. Besides, the tests are incorrect: it's okay to create a hardlink to the dangling symlink or a symlink loop as long as symlinks are not being followed.This PR fixes the tests and makes sure that
path_link
follows symlinks only when asked to.I've discovered this issue while working on the implementation of
path_link
for Windows and decided it's going to be easier to discuss the issue together with a fix.
peterhuene submitted PR Review.
sunfishcode merged PR #1284.
Last updated: Dec 23 2024 at 12:05 UTC