Stream: git-wasmtime

Topic: wasmtime / PR #1284 Path symlink follow

Wasmtime GitHub notifications bot (Mar 11 2020 at 16:08):

marmistrz opened PR #1284 from path_symlink_follow to master:

Currently, path_link doesn't take old_flags into account and always follows symlinks. Besides, the tests are incorrect: it's okay to create a hardlink to the dangling symlink or a symlink loop as long as symlinks are not being followed.

This PR fixes the tests and makes sure that path_link follows symlinks only when asked to.

I've discovered this issue while working on the implementation of path_link for Windows and decided it's going to be easier to discuss the issue together with a fix.

Wasmtime GitHub notifications bot (Mar 11 2020 at 16:08):

marmistrz requested peterhuene, kubkon, and sunfishcode for a review on PR #1284.

Wasmtime GitHub notifications bot (Mar 11 2020 at 16:08):

marmistrz requested peterhuene, kubkon, and sunfishcode for a review on PR #1284.

Wasmtime GitHub notifications bot (Mar 11 2020 at 16:08):

marmistrz requested peterhuene, kubkon, and sunfishcode for a review on PR #1284.

Wasmtime GitHub notifications bot (Mar 11 2020 at 16:09):

marmistrz updated PR #1284 from path_symlink_follow to master:

Currently, path_link doesn't take old_flags into account and always follows symlinks. Besides, the tests are incorrect: it's okay to create a hardlink to the dangling symlink or a symlink loop as long as symlinks are not being followed.

This PR fixes the tests and makes sure that path_link follows symlinks only when asked to.

I've discovered this issue while working on the implementation of path_link for Windows and decided it's going to be easier to discuss the issue together with a fix.

Wasmtime GitHub notifications bot (Mar 11 2020 at 18:45):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Mar 20 2020 at 18:59):

sunfishcode merged PR #1284.

Last updated: Nov 22 2024 at 16:03 UTC