Wasmtime GitHub notifications bot (Mar 21 2026 at 05:23): Wasmtime GitHub notifications bot (Mar 21 2026 at 05:23):vavrusa opened PR #12816 from vavrusa:marek/fix-stream-read-after-closed to bytecodealliance:main:
Hi! This is part of an issue I was trying to debug.
After the inner stream returns
0the StreamError::Closed is sent to the channel, and after picking it up in read() the stream is set as closed, and the error is returned to the caller.If the caller however tries to recv() after the socket is closed, AsyncReadStream is going to return empty list and not StreamError::Closed which is ambiguous.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 21 2026 at 05:23):vavrusa requested wasmtime-wasi-reviewers for a review on PR #12816.
Wasmtime GitHub notifications bot (Mar 21 2026 at 08:52):github-actions[bot] added the label wasi on PR #12816.
Wasmtime GitHub notifications bot (Mar 21 2026 at 14:57):alexcrichton commented on PR #12816:
Thanks! Would it be possible to add a test for this too?
Wasmtime GitHub notifications bot (Mar 23 2026 at 19:52):vavrusa updated PR #12816.
Wasmtime GitHub notifications bot (Mar 23 2026 at 19:53):vavrusa commented on PR #12816:
Yes added, thanks!
Wasmtime GitHub notifications bot (Mar 23 2026 at 20:17):dicej submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Mar 23 2026 at 20:17):dicej added PR #12816 wasi/pipe: fix AsyncReadStream returning empty list when closed to the merge queue.
Wasmtime GitHub notifications bot (Mar 23 2026 at 20:41):dicej merged PR #12816.
Wasmtime GitHub notifications bot (Mar 23 2026 at 20:41):dicej removed PR #12816 wasi/pipe: fix AsyncReadStream returning empty list when closed from the merge queue.
Last updated: Apr 12 2026 at 23:10 UTC