Stream: git-wasmtime

Topic: wasmtime / PR #12810 p3_path_link test

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 13:11):

squillace requested wasmtime-wasi-reviewers for a review on PR #12810.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 13:11):

squillace opened PR #12810 from squillace:p3_path_link to bytecodealliance:main:

a tentative test case for wasmtime p3_path_link by automating the conversion of p1 tests to p3. The first few PRs like this one are to take care to review the specific case to determine whether the automation is in fact doing the right thing. -- ralph

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 13:11):

squillace requested dicej for a review on PR #12810.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 13:11):

squillace requested wasmtime-core-reviewers for a review on PR #12810.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 16:58):

github-actions[bot] added the label wasi on PR #12810.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 15:24):

alexcrichton submitted PR review:

Thanks! Test looks to me to be a faithful translation (mostly). The missing piece here is the config().support_dangling_filesystem()-guarded part of the original test, which is a bit esoteric. I believe though that the same parts of that test can be included here too?

One thing that might also be nice is to separate out each of these individual tests to their own functions to make it a bit clearer that there's a bunch of test cases. It was all glommed together in the p1 test but I think it'd be fine to refactor-as-we-go into p3.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 15:24):

alexcrichton created PR review comment:

I think that this is fine to omit, most of the tests here don't have this variant and IIRC for the above two (or maybe just readdir?) it was a specific edge case that was being tested. Or at least I think, maybe I'm misremembering...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 15:24):

alexcrichton commented on PR #12810:

Also, of note, the CI failure with rustfmt should be easy enough to fix

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 20:56):

squillace submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 20:56):

squillace created PR review comment:

I'll have a deeper look. Thanks for thinking about this.

Last updated: Mar 23 2026 at 16:19 UTC