tolumide-ng edited PR #12805.
tolumide-ng edited PR #12805:
The
c-apicrate currently enables thegcfeature on itswasmtimedependency, even though it exposes agcfeature to control this behaviour. This prevents downstream users from disablinggc, sinceCargo.tomldoesn't allow overriding it.Changes
- Removes the explicitly set
gcfeature for thewasmtimedependency inc-api, thus enabling downstream users to specify this behaviour.- Adds ci job for building the
c-apicrate without default features, and with thegcfeatureNote
This introduces a breaking change for downstream users who may not have explicitly enabled the
gcfeature on thec-apicrate but rely on it.Closes https://github.com/bytecodealliance/wasmtime/issues/12783
tolumide-ng commented on PR #12805:
I updated the title and description of this PR to reflect the changes this PR introduces
alexcrichton commented on PR #12805:
To confirm you saw it as well @tolumide-ng, CI failed above so some changes will be needed on this PR to resolve them
tolumide-ng commented on PR #12805:
To confirm you saw it as well @tolumide-ng, CI failed above so some changes will be needed on this PR to resolve them
Seen, I'd address it. Thank you
tolumide-ng updated PR #12805.
tolumide-ng updated PR #12805.
tolumide-ng updated PR #12805.
tolumide-ng requested alexcrichton for a review on PR #12805.
github-actions[bot] added the label wasmtime:api on PR #12805.
github-actions[bot] added the label wasmtime:ref-types on PR #12805.
alexcrichton submitted PR review.
alexcrichton added PR #12805 Remove the explicit gc feature from the wasmtime dependency in the c-api crate to the merge queue.
github-actions[bot] commented on PR #12805:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton merged PR #12805.
alexcrichton removed PR #12805 Remove the explicit gc feature from the wasmtime dependency in the c-api crate from the merge queue.
Last updated: Apr 12 2026 at 23:10 UTC