Stream: git-wasmtime

Topic: wasmtime / PR #12805 Enable gc feature by default

view this post on Zulip Wasmtime GitHub notifications bot (Mar 19 2026 at 22:51):

tolumide-ng requested wasmtime-core-reviewers for a review on PR #12805.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 19 2026 at 22:51):

tolumide-ng requested cfallin for a review on PR #12805.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 19 2026 at 22:51):

tolumide-ng opened PR #12805 from tolumide-ng:fix/wasmtime-c-api-gc-update to bytecodealliance:main:

The c-api crate currently enables the gc feature on its wasmtime dependency, even though it exposes a gc feature to control this behaviour. This prevents downstream users from disabling gc, since Cargo.toml doesn't allow overriding it. However, structs like RootScope are only available when gc is enabled. Removing it from default features, without other options, would break internal implementations.

Changes

  1. Enable the gc feature via the wasmtime-c-api crate by default.
  2. Removes the explicitly set gc feature for the wasmtime dependency in c-api, thus enabling downstream users to specify this behaviour.

Closes https://github.com/bytecodealliance/wasmtime/issues/12783

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 02:32):

github-actions[bot] added the label wasmtime:c-api on PR #12805.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 05:41):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2026 at 05:41):

alexcrichton created PR review comment:

Oh for this the default feature lives here instead which includes gc, so I think it's reasonable to just from [dependencies]

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 00:13):

tolumide-ng requested wasmtime-default-reviewers for a review on PR #12805.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 00:13):

tolumide-ng updated PR #12805.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 01:31):

tolumide-ng updated PR #12805.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 01:31):

tolumide-ng created PR review comment:

Thank you for your response @alexcrichton, I am missing part of your suggestion here. Do you mean removing gc as a default feature in' wasmtime/Cargo. toml' and adding #[cfg(feature = "gc")] to the affected parts?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 01:31):

tolumide-ng submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2026 at 01:40):

tolumide-ng updated PR #12805.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2026 at 12:09):

tolumide-ng requested alexcrichton for a review on PR #12805.

Last updated: Mar 23 2026 at 16:19 UTC