Wasmtime GitHub notifications bot (Mar 17 2026 at 10:23): Wasmtime GitHub notifications bot (Mar 17 2026 at 10:23):bjorn3 opened PR #12792 from bjorn3:fix_x86_preset_names to bytecodealliance:main:
cg_clif needs them to match the target-cpu names of LLVM.
Fixes a regression from #12410.
Wasmtime GitHub notifications bot (Mar 17 2026 at 10:23):bjorn3 requested alexcrichton for a review on PR #12792.
Wasmtime GitHub notifications bot (Mar 17 2026 at 10:23):bjorn3 requested wasmtime-compiler-reviewers for a review on PR #12792.
Wasmtime GitHub notifications bot (Mar 17 2026 at 10:25):bjorn3 commented on PR #12792:
If there happens to be another patch release before Wasmtime 43 gets release, it would be nice to backport this too. It doesn't warrant a patch release on it's own as I can workaround this on the cg_clif side fairly easily.
Wasmtime GitHub notifications bot (Mar 17 2026 at 13:04):github-actions[bot] added the label cranelift on PR #12792.
Wasmtime GitHub notifications bot (Mar 17 2026 at 13:04):github-actions[bot] added the label cranelift:meta on PR #12792.
Wasmtime GitHub notifications bot (Mar 17 2026 at 15:17):alexcrichton submitted PR review:
Thanks! Can you also leave a comment saying that
-is intentionally used over_to match LLVM?
Wasmtime GitHub notifications bot (Mar 17 2026 at 15:20):bjorn3 commented on PR #12792:
There is already a comment that the names need to match LLVM at https://github.com/bytecodealliance/wasmtime/blob/a1a74d3a174e52ee71e33a076b8c55801a166dbe/cranelift/codegen/meta/src/isa/x86.rs#L121 Aside from the x86-64 ones, there are a bunch more presets using a dash in the name.
Wasmtime GitHub notifications bot (Mar 17 2026 at 16:02):alexcrichton added PR #12792 Fix the x86 preset names to the merge queue.
Wasmtime GitHub notifications bot (Mar 17 2026 at 16:35):alexcrichton removed PR #12792 Fix the x86 preset names from the merge queue.
Wasmtime GitHub notifications bot (Mar 17 2026 at 16:35):alexcrichton merged PR #12792.
Last updated: Mar 23 2026 at 16:19 UTC