Stream: git-wasmtime

Topic: wasmtime / PR #12780 Merge the wasi-tls crates into a sin...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2026 at 11:48):

badeend requested wasmtime-wasi-reviewers for a review on PR #12780.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2026 at 11:48):

badeend opened PR #12780 from badeend:merge-wasi-tls-crates to bytecodealliance:main:

This PR combines the wasi-tls crates back into a single crate with feature flags.

The current setup was never the desired state, but was a workaround to make CI work back when nativetls support was first added:

Hm ok so this is actually going to be kind of tricky. We test crates in CI with --all-features but we also test cross-compilations to various architectures, and native-tls on Linux wants OpenSSL which wants a system copy by default which isn't present for cross-compiled variants.
(..) we wouldn't test native-tls by default and we'd instead have a dedicated job for just testin native-tls, but with --all-features that's not easy :(

In this PR I work around the cross-compilation issue by simply not testing wasi-tls in run-tests.py at all. Testing wasi-tls is now handled by a dedicated CI job.

This change effectively abandons the wasmtime-wasi-tls-nativetls & wasmtime-wasi-tls-openssl crates on crates.io. Don't know if this need to be communicated somehow?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2026 at 11:48):

badeend requested alexcrichton for a review on PR #12780.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2026 at 11:48):

badeend requested wasmtime-default-reviewers for a review on PR #12780.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2026 at 11:51):

badeend edited PR #12780:

This PR combines the wasi-tls crates back into a single crate with feature flags.

The current setup was never the desired state, but was a workaround to make CI work back when nativetls support was first added:

Hm ok so this is actually going to be kind of tricky. We test crates in CI with --all-features but we also test cross-compilations to various architectures, and native-tls on Linux wants OpenSSL which wants a system copy by default which isn't present for cross-compiled variants.
(..) ideally we wouldn't test native-tls by default and we'd instead have a dedicated job for just testin native-tls, but with --all-features that's not easy :(

In this PR I work around the cross-compilation issue by simply not testing wasi-tls in run-tests.py at all. Testing wasi-tls is now handled by a dedicated CI job.

This change effectively abandons the wasmtime-wasi-tls-nativetls & wasmtime-wasi-tls-openssl crates on crates.io. Don't know if this need to be communicated somehow?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2026 at 11:53):

badeend updated PR #12780.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2026 at 15:39):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2026 at 15:39):

alexcrichton added PR #12780 Merge the wasi-tls crates into a single one with feature flags to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2026 at 15:40):

alexcrichton commented on PR #12780:

Don't know if this need to be communicated somehow?

Nah that's fine, these join a few other fringe crates of "in the wasmtime namespace and now abandoned"

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2026 at 16:04):

alexcrichton merged PR #12780.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2026 at 16:04):

alexcrichton removed PR #12780 Merge the wasi-tls crates into a single one with feature flags from the merge queue.

Last updated: Mar 23 2026 at 16:19 UTC