Stream: git-wasmtime

Topic: wasmtime / PR #1278 [wasi-common]: Hello wiggle!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 09:45):

kubkon opened PR #1278 from hello-wiggle to master:

Hello wiggle!

This PR migrates wiggle to crates/wasi-common/wiggle as a subdir of wasmtime monorepo. I've strived to preserve _all_ wiggle's git history.

All I've done so far in this PR is:

  1. migrate the history and put wiggle inside crates/wasi-common/wiggle
  2. fix wiggle's tests (i.e., paths to respective test witx files)
  3. strip wiggle of workspace status

I've left wiggle's inner folder structure intact. What I mainly mean by this is that I've not moved wiggle's subcrates generate and runtime up a level. I figured this can always be done at a later stage.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 09:45):

kubkon requested alexcrichton, pchickey, and sunfishcode for a review on PR #1278.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 09:45):

kubkon requested alexcrichton, pchickey, and sunfishcode for a review on PR #1278.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 09:45):

kubkon requested alexcrichton, pchickey, and sunfishcode for a review on PR #1278.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 13:35):

kubkon updated PR #1278 from hello-wiggle to master:

Hello wiggle!

This PR migrates wiggle to crates/wasi-common/wiggle as a subdir of wasmtime monorepo. I've strived to preserve _all_ wiggle's git history.

All I've done so far in this PR is:

  1. migrate the history and put wiggle inside crates/wasi-common/wiggle
  2. fix wiggle's tests (i.e., paths to respective test witx files)
  3. strip wiggle of workspace status

I've left wiggle's inner folder structure intact. What I mainly mean by this is that I've not moved wiggle's subcrates generate and runtime up a level. I figured this can always be done at a later stage.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:28):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:28):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:28):

sunfishcode created PR Review Comment:

Here and elsewhere, are these .gitignore files redundant now?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:29):

kubkon submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:29):

kubkon created PR Review Comment:

Indeed they are, good catch!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:34):

kubkon updated PR #1278 from hello-wiggle to master:

Hello wiggle!

This PR migrates wiggle to crates/wasi-common/wiggle as a subdir of wasmtime monorepo. I've strived to preserve _all_ wiggle's git history.

All I've done so far in this PR is:

  1. migrate the history and put wiggle inside crates/wasi-common/wiggle
  2. fix wiggle's tests (i.e., paths to respective test witx files)
  3. strip wiggle of workspace status

I've left wiggle's inner folder structure intact. What I mainly mean by this is that I've not moved wiggle's subcrates generate and runtime up a level. I figured this can always be done at a later stage.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:36):

kubkon edited PR #1278 from hello-wiggle to master:

Hello wiggle!

This PR migrates wiggle to crates/wasi-common/wiggle crates/wiggle as a subdir of wasmtime monorepo. I've strived to preserve _all_ wiggle's git history.

All I've done so far in this PR is:

  1. migrate the history and put wiggle inside crates/wasi-common/wiggle
  2. fix wiggle's tests (i.e., paths to respective test witx files)
  3. strip wiggle of workspace status

I've left wiggle's inner folder structure intact. What I mainly mean by this is that I've not moved wiggle's subcrates generate and runtime up a level. I figured this can always be done at a later stage.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:36):

kubkon edited PR #1278 from hello-wiggle to master:

Hello wiggle!

This PR migrates wiggle to crates/wasi-common/wiggle crates/wiggle as a subdir of wasmtime monorepo. I've strived to preserve _all_ wiggle's git history.

All I've done so far in this PR is:

  1. migrate the history and put wiggle inside crates/wasi-common/wiggle crates/wiggle
  2. fix wiggle's tests (i.e., paths to respective test witx files)
  3. strip wiggle of workspace status

I've left wiggle's inner folder structure intact. What I mainly mean by this is that I've not moved wiggle's subcrates generate and runtime up a level. I figured this can always be done at a later stage.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 16:39):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 17:11):

kubkon merged PR #1278.

Last updated: Nov 22 2024 at 17:03 UTC