Stream: git-wasmtime

Topic: wasmtime / PR #12764 [Cranelift] add type-aware rotate op...

Wasmtime GitHub notifications bot (Mar 12 2026 at 02:12):

bongjunj opened PR #12764 from bongjunj:ty-aware-ops to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Related to #12759. Rotation operations are sensitive to type width; therefore their semantics should change per the operands' type rather than being fixed to u64, u32, and so on.

Wasmtime GitHub notifications bot (Mar 12 2026 at 02:12):

bongjunj requested cfallin for a review on PR #12764.

Wasmtime GitHub notifications bot (Mar 12 2026 at 02:12):

bongjunj requested wasmtime-compiler-reviewers for a review on PR #12764.

Wasmtime GitHub notifications bot (Mar 12 2026 at 06:00):

github-actions[bot] added the label cranelift on PR #12764.

Wasmtime GitHub notifications bot (Mar 12 2026 at 06:00):

github-actions[bot] added the label isle on PR #12764.

Wasmtime GitHub notifications bot (Mar 12 2026 at 06:01):

github-actions[bot] commented on PR #12764:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 13 2026 at 19:12):

cfallin submitted PR review:

Thanks! A few thoughts below but the logic generally looks good to me.

Wasmtime GitHub notifications bot (Mar 13 2026 at 19:12):

cfallin created PR review comment:

Can we put a debug_assert here that bits is a power of two? This is true for all of our types today but I don't want to bake the assumption in without something guarding it.

Wasmtime GitHub notifications bot (Mar 13 2026 at 19:12):

cfallin created PR review comment:

Likewise here (debug-assert power-of-two).

Wasmtime GitHub notifications bot (Mar 13 2026 at 19:12):

cfallin created PR review comment:

Now that we have these helpers in the prelude, we should be able to implement rotl/rotr constant propagation rules too, right? It seems odd to have just the rule in this PR (for rotr-of-select-of-constants) -- can we add simple cprop as well?

Wasmtime GitHub notifications bot (Mar 14 2026 at 05:35):

bongjunj updated PR #12764.

Wasmtime GitHub notifications bot (Mar 14 2026 at 05:36):

bongjunj commented on PR #12764:

• Added debug_assert statements
• Added rotr, rotl cprops and filetests for them

Wasmtime GitHub notifications bot (Mar 14 2026 at 05:36):

bongjunj edited a comment on PR #12764:

Thanks for the review!

• Added debug_assert statements
• Added rotr, rotl cprops and filetests for them

Wasmtime GitHub notifications bot (Mar 16 2026 at 21:19):

cfallin submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Mar 16 2026 at 21:19):

cfallin added PR #12764 [Cranelift] add type-aware rotate operations to the merge queue.

Wasmtime GitHub notifications bot (Mar 16 2026 at 21:44):

cfallin merged PR #12764.

Wasmtime GitHub notifications bot (Mar 16 2026 at 21:44):

cfallin removed PR #12764 [Cranelift] add type-aware rotate operations from the merge queue.

Last updated: Mar 23 2026 at 16:19 UTC