Stream: git-wasmtime

Topic: wasmtime / PR #12736 Set current thread before lowering s...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2026 at 17:02):

TartanLlama opened PR #12736 from TartanLlama:sy/future-stream-thread to bytecodealliance:main:

The current thread is not set before lowering the results of stream/future reads, which can potentially call realloc.

Putting this up as a draft for now as I'm off tomorrow, will add some tests for this on Monday.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2026 at 20:54):

github-actions[bot] added the label wasmtime:api on PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2026 at 20:57):

alexcrichton submitted PR review:

Longer-term (@dicej you may have thoughts on this too) I feel like the juggling here is pretty brittle and it seems like we should have a new argument to LowerContext::new or something like that. I'm not sure if that would work well given all the various juggling involved, but might be something worth considering.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2026 at 20:57):

alexcrichton created PR review comment:

I think this argument is always self.concurrent_state_mut().current_guest_thread()?, so could the argument be dropped and that inlined directly below?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2026 at 20:57):

alexcrichton created PR review comment:

Mind leaving comments here, and above, for why the current thread is set?

Also, is this something where we want to restore the previous thread after this finishes?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2026 at 14:27):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2026 at 14:52):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2026 at 14:53):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2026 at 15:45):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2026 at 15:46):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 12:51):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 12:54):

TartanLlama edited PR #12736:

The current thread is not set before lowering the results of stream/future reads, which can potentially call realloc.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 12:54):

TartanLlama has marked PR #12736 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 12:54):

TartanLlama requested pchickey for a review on PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 12:54):

TartanLlama requested wasmtime-core-reviewers for a review on PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 13:44):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 13:46):

TartanLlama updated PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 14:28):

alexcrichton added PR #12736 Set current thread before lowering stream/future reads to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 14:53):

alexcrichton merged PR #12736.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2026 at 14:53):

alexcrichton removed PR #12736 Set current thread before lowering stream/future reads from the merge queue.

Last updated: Mar 23 2026 at 16:19 UTC