Stream: git-wasmtime

Topic: wasmtime / PR #12719 Miscellaneous feature-related build ...

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:35):

PiotrSikora opened PR #12719 from PiotrSikora:misc to bytecodealliance:main:

Most found with cargo-all-features.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:35):

PiotrSikora requested alexcrichton for a review on PR #12719.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:35):

PiotrSikora requested wasmtime-core-reviewers for a review on PR #12719.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:35):

PiotrSikora requested wasmtime-default-reviewers for a review on PR #12719.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:36):

PiotrSikora commented on PR #12719:

I found cargo-all-features and went down the rabbit hole finding and fixing more build errors for some unique combinations of features.

But adding it to the CI might be quite expensive.

Even running it only for the wasmtime crate (as the one that's consumed by other projects):

• testing all features alone - 44 runs of cargo check,
• testing all combinations of any 2 features - 947 runs of cargo check,
• testing all combinations of any 3 features - 13,288 runs of cargo check.

In comparison, wasmtime's current feature matrix is tested for 39 hand selected combinations.

cc @dicej

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:36):

PiotrSikora edited a comment on PR #12719:

(split off from #12706)

I found cargo-all-features and went down the rabbit hole finding and fixing more build errors for some unique combinations of features.

But adding it to the CI might be quite expensive.

Even running it only for the wasmtime crate (as the one that's consumed by other projects):

• testing all features alone - 44 runs of cargo check,
• testing all combinations of any 2 features - 947 runs of cargo check,
• testing all combinations of any 3 features - 13,288 runs of cargo check.

In comparison, wasmtime's current feature matrix is tested for 39 hand selected combinations.

cc @dicej

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:40):

PiotrSikora submitted PR review.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:40):

PiotrSikora created PR review comment:

We should probably remove this if you don't want to add cargo all-features check to the CI.

Wasmtime GitHub notifications bot (Mar 04 2026 at 22:44):

PiotrSikora updated PR #12719.

Wasmtime GitHub notifications bot (Mar 04 2026 at 22:47):

PiotrSikora updated PR #12719.

Wasmtime GitHub notifications bot (Mar 04 2026 at 23:41):

PiotrSikora updated PR #12719.

Wasmtime GitHub notifications bot (Mar 04 2026 at 23:46):

PiotrSikora updated PR #12719.

Wasmtime GitHub notifications bot (Mar 05 2026 at 02:32):

github-actions[bot] added the label pulley on PR #12719.

Wasmtime GitHub notifications bot (Mar 05 2026 at 02:32):

github-actions[bot] added the label wasmtime:api on PR #12719.

Wasmtime GitHub notifications bot (Mar 05 2026 at 02:33):

github-actions[bot] commented on PR #12719:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "pulley", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 05 2026 at 03:41):

PiotrSikora edited a comment on PR #12719:

(split off from #12706)

I found cargo-all-features and went down the rabbit hole finding and fixing more build errors for some unique combinations of features.

But adding it to the CI might be quite expensive.

Even running it only for the wasmtime crate (as the one that's consumed by other projects):

• testing all features alone - 44 runs of cargo check,
• testing all combinations of any 2 features - 947 runs of cargo check and around 44 GB of disk space,
• testing all combinations of any 3 features - 13,288 runs of cargo check.

In comparison, wasmtime's current feature matrix is tested for 39 hand selected combinations.

cc @dicej

Wasmtime GitHub notifications bot (Mar 05 2026 at 15:41):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Mar 05 2026 at 15:41):

alexcrichton created PR review comment:

Yeah I'd say let's leave this out for now because cargo all-features check is a bit too heavyweight for us. If you'd like though adding any particularly interesting set of features to the check matrix CI is reasoanble, and for now that's our sort of halfway-state.

Wasmtime GitHub notifications bot (Mar 05 2026 at 16:45):

PiotrSikora updated PR #12719.

Wasmtime GitHub notifications bot (Mar 05 2026 at 16:58):

PiotrSikora submitted PR review.

Wasmtime GitHub notifications bot (Mar 05 2026 at 16:58):

PiotrSikora created PR review comment:

Yeah, I agree. Removed.

FYI, with fixes in this PR cargo check runs without any warnings or errors:

• in wasmtime crate for all combinations of any 2 features and all combinations of any 2 features _and_ the "runtime" feature,
• in pulley crate for all combinations of any number of features.

Wasmtime GitHub notifications bot (Mar 05 2026 at 17:03):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 05 2026 at 17:03):

alexcrichton created PR review comment:

Nice, many thanks!

Wasmtime GitHub notifications bot (Mar 05 2026 at 17:03):

alexcrichton has enabled auto merge for PR #12719.

Wasmtime GitHub notifications bot (Mar 05 2026 at 17:35):

alexcrichton added PR #12719 Miscellaneous feature-related build fixes. to the merge queue

Wasmtime GitHub notifications bot (Mar 05 2026 at 18:13):

alexcrichton merged PR #12719.

Wasmtime GitHub notifications bot (Mar 05 2026 at 18:13):

alexcrichton removed PR #12719 Miscellaneous feature-related build fixes. from the merge queue

Last updated: Mar 23 2026 at 16:19 UTC