Stream: git-wasmtime

Topic: wasmtime / PR #12717 Cranelift: ISLE: add type parameters...

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:30):

avanhatt opened PR #12717 from avanhatt:ty-params-3-4 to bytecodealliance:main:

Discussed in issue https://github.com/bytecodealliance/wasmtime/issues/12716.

Right now in ISLE, most clif instructions have a type parameter in opt for the midend, but not in lowering (e.g., iadd ty x y) vs (iadd x y). From our previous discussions (@cfallin @fitzgen), this is mostly due to the order of implementation rather than a design decision. For our verification work, it's useful to also have the type parameters in the lowering terms, as well, if they produce values (e.g., excluding things like store).

This changes uses scripting to automatically change the many relevant rules, by programmatically adding _. Over time, we can update rules to remove now-simplifiable has_ty terms.

This is based on an earlier commit/script from @mmcloughlin , with changes to merge into upstream after #10524.

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:30):

avanhatt requested alexcrichton for a review on PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:30):

avanhatt requested wasmtime-compiler-reviewers for a review on PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:31):

avanhatt submitted PR review.

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:31):

avanhatt created PR review comment:

CC @fitzgen this is not the cleanest, but I wasn't sure about adding another result to the match tuple creation you added above. The alternative is to add another inst_data_value variant to the backend with a distinct signature. Thoughts?

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:37):

avanhatt converted PR #12717 Cranelift: ISLE: add type parameters to most clif terms in lower to a draft.

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:39):

avanhatt commented on PR #12717:

Oops, hadn't built the pulley_shared target locally, converting to draft.

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:44):

avanhatt updated PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 17:47):

avanhatt updated PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 18:03):

avanhatt has marked PR #12717 as ready for review.

Wasmtime GitHub notifications bot (Mar 04 2026 at 18:11):

alexcrichton unassigned alexcrichton from PR #12717 Cranelift: ISLE: add type parameters to most clif terms in lower.

Wasmtime GitHub notifications bot (Mar 04 2026 at 18:11):

alexcrichton requested cfallin for a review on PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 18:34):

fitzgen created PR review comment:

I think this needs a trailing space:

                    "_ "

Wasmtime GitHub notifications bot (Mar 04 2026 at 18:34):

fitzgen submitted PR review:

LGTM

Wasmtime GitHub notifications bot (Mar 04 2026 at 19:07):

avanhatt updated PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:51):

github-actions[bot] added the label cranelift on PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:51):

github-actions[bot] added the label cranelift:area:machinst on PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:52):

github-actions[bot] added the label cranelift:area:aarch64 on PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:52):

github-actions[bot] added the label cranelift:area:x64 on PR #12717.

Wasmtime GitHub notifications bot (Mar 04 2026 at 21:52):

github-actions[bot] added the label cranelift:meta on PR #12717.

Wasmtime GitHub notifications bot (Mar 11 2026 at 22:12):

cfallin submitted PR review:

Looks fine to me too -- let's go ahead and merge this and then we can iterate from there (e.g. for side-effecting operators and such). Thanks!

Wasmtime GitHub notifications bot (Mar 11 2026 at 22:13):

cfallin added PR #12717 Cranelift: ISLE: add type parameters to most clif terms in lower to the merge queue.

Wasmtime GitHub notifications bot (Mar 11 2026 at 22:37):

cfallin merged PR #12717.

Wasmtime GitHub notifications bot (Mar 11 2026 at 22:37):

cfallin removed PR #12717 Cranelift: ISLE: add type parameters to most clif terms in lower from the merge queue.

Last updated: Mar 23 2026 at 16:19 UTC