Wasmtime GitHub notifications bot (Mar 03 2026 at 22:36): Wasmtime GitHub notifications bot (Mar 03 2026 at 22:36):fitzgen opened PR #12712 from fitzgen:fallible-alloc-btree-map to bytecodealliance:main:
Depends on https://github.com/bytecodealliance/wasmtime/pull/12710
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:36):fitzgen requested alexcrichton for a review on PR #12712.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:36):fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12712.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:36):fitzgen requested wasmtime-compiler-reviewers for a review on PR #12712.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:36):fitzgen requested wasmtime-core-reviewers for a review on PR #12712.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:36):fitzgen requested wasmtime-default-reviewers for a review on PR #12712.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:42):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:42):fitzgen created PR review comment:
Oh I didn't actually mean to commit this, it is just what I used to get the memory usage numbers here, but I guess I can leave it here if people want?
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:59):alexcrichton submitted PR review:
Oof man that's a big one, but looks great!
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:59):alexcrichton created PR review comment:
Could
clear()be added tocranelift-bforest? (or would that not make sense?)
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:59):alexcrichton created PR review comment:
Similar concern to above
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:59):alexcrichton created PR review comment:
This feels a bit too strong even for debug assertions since this is basically quadratic behavior. I think it's probably fine to defer this to tests detecting situations like this.
Basically I think it's fine for debug mode to have extra checks, but changing big-O I think should still be avoided.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:59):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 03 2026 at 22:59):alexcrichton created PR review comment:
Seems fine to me yeah to leave
Wasmtime GitHub notifications bot (Mar 04 2026 at 03:29):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Mar 04 2026 at 03:29):fitzgen created PR review comment:
That method does exist, but it goes through and deallocates each node in the map within the context of the forest. But since the forest isn't shared across multiple maps in this case, that is wasted work, and simply clearing the whole forest and replacing our map with the new/empty/default map is faster and simpler.
Wasmtime GitHub notifications bot (Mar 04 2026 at 05:05):github-actions[bot] added the label cranelift on PR #12712.
Wasmtime GitHub notifications bot (Mar 04 2026 at 05:05):github-actions[bot] added the label fuzzing on PR #12712.
Wasmtime GitHub notifications bot (Mar 04 2026 at 05:05):github-actions[bot] commented on PR #12712:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 04 2026 at 16:23):fitzgen updated PR #12712.
Wasmtime GitHub notifications bot (Mar 04 2026 at 16:23):fitzgen has enabled auto merge for PR #12712.
Wasmtime GitHub notifications bot (Mar 04 2026 at 16:36):fitzgen added PR #12712 Add an OOM-handling BTreeMap implementation to the merge queue.
Wasmtime GitHub notifications bot (Mar 04 2026 at 17:28):github-merge-queue[bot] removed PR #12712 Add an OOM-handling BTreeMap implementation from the merge queue.
Wasmtime GitHub notifications bot (Mar 04 2026 at 18:16):fitzgen updated PR #12712.
Wasmtime GitHub notifications bot (Mar 04 2026 at 18:17):fitzgen has enabled auto merge for PR #12712.
Wasmtime GitHub notifications bot (Mar 04 2026 at 18:30):fitzgen added PR #12712 Add an OOM-handling BTreeMap implementation to the merge queue.
Wasmtime GitHub notifications bot (Mar 04 2026 at 18:51):github-merge-queue[bot] removed PR #12712 Add an OOM-handling BTreeMap implementation from the merge queue.
Wasmtime GitHub notifications bot (Mar 04 2026 at 19:10):fitzgen added PR #12712 Add an OOM-handling BTreeMap implementation to the merge queue.
Wasmtime GitHub notifications bot (Mar 04 2026 at 19:10):fitzgen commented on PR #12712:
(Network error)
Wasmtime GitHub notifications bot (Mar 04 2026 at 19:34):fitzgen merged PR #12712.
Wasmtime GitHub notifications bot (Mar 04 2026 at 19:34):fitzgen removed PR #12712 Add an OOM-handling BTreeMap implementation from the merge queue.
Last updated: Mar 23 2026 at 16:19 UTC