Stream: git-wasmtime

Topic: wasmtime / PR #12710 Add range iterators and immutable cu...

Wasmtime GitHub notifications bot (Mar 03 2026 at 22:35):

fitzgen opened PR #12710 from fitzgen:range-iter-and-imm-cursor-for-bforest-map to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 03 2026 at 22:35):

fitzgen requested cfallin for a review on PR #12710.

Wasmtime GitHub notifications bot (Mar 03 2026 at 22:35):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #12710.

Wasmtime GitHub notifications bot (Mar 03 2026 at 22:49):

cfallin submitted PR review:

LGTM modulo one question below -- thanks!

Wasmtime GitHub notifications bot (Mar 03 2026 at 22:49):

cfallin created PR review comment:

Do we need the check for the start-bound here? Reading the code that produces the iterator and the started logic above, it looks like the underlying cursor is always initialized to the first element, and we know the elements will be visited in sorted order; so is it sufficient to only check the end (and rename this to is_within_end_bound or something similar)? If not, could we add a comment here describing why we need this check too?

Wasmtime GitHub notifications bot (Mar 04 2026 at 01:05):

github-actions[bot] added the label cranelift on PR #12710.

Wasmtime GitHub notifications bot (Mar 04 2026 at 03:27):

fitzgen updated PR #12710.

Wasmtime GitHub notifications bot (Mar 04 2026 at 03:28):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 04 2026 at 03:28):

fitzgen created PR review comment:

Good catch. I also realized there was a bug when the range's start wasn't in the map. Pushed a commit to address both and some more testing.

Wasmtime GitHub notifications bot (Mar 04 2026 at 03:28):

fitzgen has enabled auto merge for PR #12710.

Wasmtime GitHub notifications bot (Mar 04 2026 at 03:41):

fitzgen added PR #12710 Add range iterators and immutable cursors for cranelift_bforest::Map to the merge queue

Wasmtime GitHub notifications bot (Mar 04 2026 at 04:04):

fitzgen merged PR #12710.

Wasmtime GitHub notifications bot (Mar 04 2026 at 04:04):

fitzgen removed PR #12710 Add range iterators and immutable cursors for cranelift_bforest::Map from the merge queue

Last updated: Mar 23 2026 at 16:19 UTC