Wasmtime GitHub notifications bot (Mar 02 2026 at 06:45): Wasmtime GitHub notifications bot (Mar 02 2026 at 06:45):ahqsoftwares opened PR #12701 from ahqsoftwares:main to bytecodealliance:main:
issue #12679
As i mentioned in https://github.com/bytecodealliance/wasmtime/issues/12679#issuecomment-3980345081
this PR only adds AtomicOrdering enum and sets the implementation to Default (SeqCst) for compatibility.This PR Also upgrades the test clif files, internal-cranelfit as well.
The Lowering is set to SeqCst by default.
Changes:
- Added the
AtomicOrderingenum to the instructions (atomic_load, atomic_store, atomic_rmw, atomic_cas, fence)- CDSL has been updated to reflect the changes
- The internal
wasmtime-cranelifthas to updated to exclusively use the default AtomicOrdering (SeqCst) to comply with webassembly expectations.- 45+ clif test files have been updated to reflect the change.
[!IMPORTANT]
This implementation currently increases the size of InstructionData to 24 bytes. I am fully aware this is a performance regression against the 16-byte target mentioned in the codebase.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 02 2026 at 06:46):ahqsoftwares updated PR #12701.
Wasmtime GitHub notifications bot (Mar 02 2026 at 08:58):github-actions[bot] added the label cranelift:area:machinst on PR #12701.
Wasmtime GitHub notifications bot (Mar 02 2026 at 08:58):github-actions[bot] added the label cranelift:area:aarch64 on PR #12701.
Wasmtime GitHub notifications bot (Mar 02 2026 at 08:58):github-actions[bot] added the label cranelift on PR #12701.
Wasmtime GitHub notifications bot (Mar 02 2026 at 08:58):github-actions[bot] added the label cranelift:meta on PR #12701.
Wasmtime GitHub notifications bot (Mar 02 2026 at 08:58):github-actions[bot] added the label cranelift:area:x64 on PR #12701.
Wasmtime GitHub notifications bot (Mar 02 2026 at 11:31):ahqsoftwares updated PR #12701.
Last updated: Mar 23 2026 at 16:19 UTC