Stream: git-wasmtime

Topic: wasmtime / PR #12682 Do not allocate for `wasmtime::Modul...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:08):

fitzgen opened PR #12682 from fitzgen:module-imports-proper-iterator to bytecodealliance:main:

Depends on https://github.com/bytecodealliance/wasmtime/pull/12681

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:08):

fitzgen requested alexcrichton for a review on PR #12682.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:08):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #12682.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:08):

fitzgen requested wasmtime-core-reviewers for a review on PR #12682.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:29):

alexcrichton submitted PR review:

I think we can probably skip the manual impl here, removing .collect().into_iter() works for me locally, so while this may have been required historically I think it's just an artifact that can be removed now?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:40):

fitzgen commented on PR #12682:

I think we can probably skip the manual impl here, removing .collect().into_iter() works for me locally, so while this may have been required historically I think it's just an artifact that can be removed now?

Oh nice, I should have checked that first, heh

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:41):

fitzgen updated PR #12682.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:44):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:48):

fitzgen updated PR #12682.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 22:49):

fitzgen has enabled auto merge for PR #12682.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 23:01):

fitzgen added PR #12682 Do not allocate for wasmtime::Module::imports iterator to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 23:25):

fitzgen merged PR #12682.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2026 at 23:25):

fitzgen removed PR #12682 Do not allocate for wasmtime::Module::imports iterator from the merge queue.

Last updated: Mar 23 2026 at 16:19 UTC