fitzgen opened PR #12670 from fitzgen:handle-oom-in-environ-wasm-func-type to bytecodealliance:main:
It should also not
#[derive(Clone)]anymore, justTryClone, which propagates out to a bunch of other types as well.And while we are here:
- Rename its "returns" to "results" to match Wasmtime's public API and also the Wasm text format.
- Store both its params and results in a single allocation.
- Shrink its size on 64-bit architectures by storing its param- and result-GC-type counts as
u32s rather thanusizes.Depends on https://github.com/bytecodealliance/wasmtime/pull/12669
fitzgen requested wasmtime-compiler-reviewers for a review on PR #12670.
fitzgen requested cfallin for a review on PR #12670.
fitzgen requested wasmtime-core-reviewers for a review on PR #12670.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Random thought: maybe a built-in
clone_panic_on_oom()method onTryClone?
fitzgen submitted PR review.
fitzgen created PR review comment:
Ah! Good idea, I'll do that in a follow up PR.
fitzgen updated PR #12670.
fitzgen updated PR #12670.
fitzgen has enabled auto merge for PR #12670.
fitzgen updated PR #12670.
fitzgen added PR #12670 Handle OOM in wasmtime_environ::types::WasmFuncType to the merge queue
fitzgen merged PR #12670.
fitzgen removed PR #12670 Handle OOM in wasmtime_environ::types::WasmFuncType from the merge queue
Last updated: Mar 23 2026 at 16:19 UTC