cfallin requested alexcrichton for a review on PR #12664.
cfallin opened PR #12664 from cfallin:debugging-early-epoch-yield-vmctx to bytecodealliance:main:
Epoch yields emit debug events, and the debug event handler can walk the stack and look at the instance associated with each frame, which requires
vmctx. We weren't setting thevmctxslot until after the epoch check in the function preamble, exposing a null or uninitialized slot to the accessor. This PR fixes that by hoisting the initialization to the very top of the preamble.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
cfallin requested wasmtime-compiler-reviewers for a review on PR #12664.
cfallin requested wasmtime-core-reviewers for a review on PR #12664.
alexcrichton submitted PR review.
alexcrichton added PR #12664 Debugging: set vmctx slot before top-of-function epoch yield point. to the merge queue
github-merge-queue[bot] removed PR #12664 Debugging: set vmctx slot before top-of-function epoch yield point. from the merge queue
cfallin added PR #12664 Debugging: set vmctx slot before top-of-function epoch yield point. to the merge queue
cfallin merged PR #12664.
cfallin removed PR #12664 Debugging: set vmctx slot before top-of-function epoch yield point. from the merge queue
Last updated: Mar 23 2026 at 16:19 UTC