Wasmtime GitHub notifications bot (Feb 24 2026 at 22:13): Wasmtime GitHub notifications bot (Feb 24 2026 at 22:13):fitzgen opened PR #12659 from fitzgen:concurrency-disabled-host-call-panic to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 24 2026 at 22:13):fitzgen requested alexcrichton for a review on PR #12659.
Wasmtime GitHub notifications bot (Feb 24 2026 at 22:13):fitzgen requested wasmtime-core-reviewers for a review on PR #12659.
Wasmtime GitHub notifications bot (Feb 24 2026 at 22:18):alexcrichton submitted PR review:
Ah this was part of a recent refactor where these calls can't be skipped so they can't just return
Ok(())and work correctly. Can you add calls toself.enter_call_not_concurrent()andself.exit_call_not_concurrent()in the disabled case?For a test for this, can you add a test with concurrency_supoprt disabled and a host call with a
borrow<T>resource is done? I think it should panic and/or cause problems with the PR as-is, but if not I can help whip up a more involved test.
Wasmtime GitHub notifications bot (Feb 24 2026 at 22:18):alexcrichton submitted PR review:
er, sorry, wrong button
Wasmtime GitHub notifications bot (Feb 24 2026 at 23:15):fitzgen updated PR #12659.
Wasmtime GitHub notifications bot (Feb 24 2026 at 23:15):fitzgen requested alexcrichton for a review on PR #12659.
Wasmtime GitHub notifications bot (Feb 24 2026 at 23:16):fitzgen updated PR #12659.
Wasmtime GitHub notifications bot (Feb 25 2026 at 00:02):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 25 2026 at 00:02):alexcrichton added PR #12659 Do not panic on host calls when CM concurrency support is disabled to the merge queue.
Wasmtime GitHub notifications bot (Feb 25 2026 at 00:33):alexcrichton merged PR #12659.
Wasmtime GitHub notifications bot (Feb 25 2026 at 00:33):alexcrichton removed PR #12659 Do not panic on host calls when CM concurrency support is disabled from the merge queue.
Last updated: Mar 23 2026 at 16:19 UTC