Wasmtime GitHub notifications bot (Mar 09 2020 at 18:12): Wasmtime GitHub notifications bot (Mar 09 2020 at 18:12):fitzgen opened PR #1265 from limit-all-api-calls to master:
To avoid libfuzzer timeouts, limit the total number of API calls we generate in
theapi_callsfuzz target. We were already limiting the number of exported
function calls we made, and this extends the limit to all API calls.
Wasmtime GitHub notifications bot (Mar 10 2020 at 14:22):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2020 at 14:22):alexcrichton created PR Review Comment:
I'm not too familiar with the
Arbitrarytrait, but is there perhaps a way that we can hook in here? Is there a way to indicate that we want at most a particular number of API calls?
Wasmtime GitHub notifications bot (Mar 10 2020 at 14:22):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2020 at 16:25):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2020 at 16:25):fitzgen created PR Review Comment:
We have
int_in_rangebut this draws from the front of the byte string, rather than the end, like lengths do. The mechanism that lengths use to get an integer in a range from the end of the byte string isn't a public API, unfortunately. (Reason lengths should be drawn from the end of the byte string: https://github.com/rust-fuzz/libfuzzer-sys/blob/0c450753/libfuzzer/utils/FuzzedDataProvider.h#L92-L97)Overall, I don't think it really matters too much, though.
Wasmtime GitHub notifications bot (Mar 10 2020 at 16:28):alexcrichton merged PR #1265.
Wasmtime GitHub notifications bot (Mar 10 2020 at 16:38):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2020 at 16:38):fitzgen created PR Review Comment:
Filed https://github.com/rust-fuzz/arbitrary/issues/36 for posterity
Last updated: Oct 23 2024 at 20:03 UTC