Stream: git-wasmtime

Topic: wasmtime / PR #12632 Skip on_complete for already-cancell...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2026 at 01:43):

jellevandenhooff opened PR #12632 from jellevandenhooff:fix-on-complete-after-cancel to bytecodealliance:main:

While working on a program with many outgoing DNS requests that also got cancelled I ran into a race with subtask management:

crates/wasmtime/src/runtime/component/concurrent.rs:5108:37:
     called `Result::unwrap()` on an `Err` value: NotPresent

The included reproducing test fails before the fix and works after.

Code and commit message by Claude. It looks sane to me, but I am not sure about eating the error in the branch; please consider if this makes sense. If the commit message is too long I am happy to rewrite it human-style.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2026 at 01:43):

jellevandenhooff requested pchickey for a review on PR #12632.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2026 at 01:43):

jellevandenhooff requested wasmtime-core-reviewers for a review on PR #12632.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2026 at 05:04):

github-actions[bot] added the label wasmtime:api on PR #12632.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2026 at 06:01):

jellevandenhooff updated PR #12632.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2026 at 06:06):

jellevandenhooff updated PR #12632.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 21 2026 at 06:08):

jellevandenhooff commented on PR #12632:

Okay, then ran into a similar but related issue where a cancelled task's on_complete handler was able to steal a replacement task's on_complete. The test is kind of gnarly and I am concerned it's not deterministic. What it tries to show is that:


Last updated: Feb 24 2026 at 04:36 UTC