Stream: git-wasmtime

Topic: wasmtime / PR #12604 chore: avoid panic when parsing --di...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2026 at 09:40):

Ocheretovich requested pchickey for a review on PR #12604.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2026 at 09:40):

Ocheretovich requested wasmtime-core-reviewers for a review on PR #12604.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2026 at 09:40):

Ocheretovich opened PR #12604 from Ocheretovich:main to bytecodealliance:main:

Avoid potential panic when parsing --dir argument by returning a proper error instead of unwrapping

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2026 at 17:45):

pchickey submitted PR review:

Did you find an input that can create this panic? From the docs of split

https://doc.rust-lang.org/std/primitive.str.html#method.split

Returns an iterator over substrings of this string slice, separated by characters matched by a pattern.
...
If there are no matches the full string slice is returned as the only item in the iterator.

by my reading, the iterator given by split will always contain at least one value, therefore the first call to next will always give Some.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2026 at 17:50):

pchickey closed without merge PR #12604.

Last updated: Feb 24 2026 at 04:36 UTC