fitzgen opened PR #12584 from fitzgen:use-oom-handling-vec-in-environ-module to bytecodealliance:main:
Depends on
fitzgen requested alexcrichton for a review on PR #12584.
fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12584.
fitzgen requested wasmtime-core-reviewers for a review on PR #12584.
alexcrichton submitted PR review:
Related, but not blocking thought on this:
collections::Vecis a bummer. Bikeshedding: if we were to renamewasmtime_environ::collections::Vec, what would we rename it to?
TryVec- perhaps accurate, but long.TryIndexMapis a lot.TVec- personally I kinda like the ring of "letter plus collection". It's short and clearly "notstd"WVec- wasmtime's vec?XVec- any other random letterOomVec- I don't like this b/c the container handles OOMs, it doesn't make OOMsVecT(orVecWor such) - subjectively not a fanWDYT about maybe putting "t" or "T" in front of all the collections? For example
tvec![...]andTVecandTHashMap? (or any other letter really)
github-actions[bot] added the label fuzzing on PR #12584.
github-actions[bot] added the label wasmtime:api on PR #12584.
github-actions[bot] commented on PR #12584:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen commented on PR #12584:
Related, but not blocking thought on this:
collections::Vecis a bummer. Bikeshedding: if we were to renamewasmtime_environ::collections::Vec, what would we rename it to?* `TryVec` - perhaps accurate, but long. `TryIndexMap` is a lot. * `TVec` - personally I kinda like the ring of "letter plus collection". It's short and clearly "not `std`" * `WVec` - wasmtime's vec? * `XVec` - any other random letter * `OomVec` - I don't like this b/c the container handles OOMs, it doesn't make OOMs * `VecT` (or `VecW` or such) - subjectively not a fanWDYT about maybe putting "t" or "T" in front of all the collections? For example
tvec![...]andTVecandTHashMap? (or any other letter really)Yeah, I think something like this is inevitable if we aren't going to eventually move everything over to the OOM-handling versions.
I kind of hate all the potential names ~equally (no shade to you, they are basically the same candidates I've come up with myself).
I guess I like
WVecthe most maybe? Or if we are going to choose an arbitrary letter, might as well choose a cool one likeXVecor something lol
fitzgen updated PR #12584.
fitzgen has enabled auto merge for PR #12584.
fitzgen added PR #12584 Use our OOM-handling Vec in wasmtime_environ::Module to the merge queue
fitzgen merged PR #12584.
fitzgen removed PR #12584 Use our OOM-handling Vec in wasmtime_environ::Module from the merge queue
Last updated: Feb 24 2026 at 04:36 UTC