Wasmtime GitHub notifications bot (Feb 11 2026 at 21:33): Wasmtime GitHub notifications bot (Feb 11 2026 at 21:33):cfallin opened PR #12572 from cfallin:miri-mmap-file-seek to bytecodealliance:main:
The constructor takes a
&Filebut&Filestill allows mutation of the underlying state, e.g., the seek position. It turns out that this matters when we try toMmap::from_filemore than once, e.g. when enabling guest debugging and thus mapping private copies of code.No test yet as this will be covered by upcoming miri coverage of guest debugging.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 11 2026 at 21:33):cfallin requested fitzgen for a review on PR #12572.
Wasmtime GitHub notifications bot (Feb 11 2026 at 21:33):cfallin requested wasmtime-core-reviewers for a review on PR #12572.
Wasmtime GitHub notifications bot (Feb 11 2026 at 21:34):cfallin commented on PR #12572:
(Found while trying to add miri coverage to #12566)
Wasmtime GitHub notifications bot (Feb 11 2026 at 21:38):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 11 2026 at 21:39):cfallin has enabled auto merge for PR #12572.
Wasmtime GitHub notifications bot (Feb 11 2026 at 21:47):cfallin added PR #12572 sys/miri: fix Mmap::from_file to seek to start of file. to the merge queue
Wasmtime GitHub notifications bot (Feb 11 2026 at 22:30):cfallin merged PR #12572.
Wasmtime GitHub notifications bot (Feb 11 2026 at 22:30):cfallin removed PR #12572 sys/miri: fix Mmap::from_file to seek to start of file. from the merge queue
Last updated: Feb 24 2026 at 04:36 UTC