alexcrichton requested dicej for a review on PR #12567.
alexcrichton opened PR #12567 from alexcrichton:yield-dont-sleep to bytecodealliance:main:
Use cooperative yields instead of sleeps to make tests more deterministic and also avoid them unnecessarily taking up test parallelism by sleeping. Yielding should have the same effect in terms of testing by exercising behavior returning
Pendingin futures, so there's no expected loss in test coverage here.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-core-reviewers for a review on PR #12567.
dicej created PR review comment:
Is the
100here just an artifact from when we slept 100ms, or did we really need to yield 100 times (or at least more than 10 or so)?
dicej submitted PR review.
alexcrichton updated PR #12567.
alexcrichton has enabled auto merge for PR #12567.
alexcrichton added PR #12567 Yield instead of sleep in component-async-tests to the merge queue.
github-merge-queue[bot] removed PR #12567 Yield instead of sleep in component-async-tests from the merge queue.
alexcrichton added PR #12567 Yield instead of sleep in component-async-tests to the merge queue.
github-merge-queue[bot] removed PR #12567 Yield instead of sleep in component-async-tests from the merge queue.
alexcrichton added PR #12567 Yield instead of sleep in component-async-tests to the merge queue.
alexcrichton merged PR #12567.
alexcrichton removed PR #12567 Yield instead of sleep in component-async-tests from the merge queue.
Last updated: Feb 24 2026 at 04:36 UTC