ricochet opened PR #12557 from ricochet:rev-0.3.0-rc-2026-02-09 to bytecodealliance:main.
ricochet submitted PR review.
ricochet created PR review comment:
The primary changes in this rc were driven by: https://github.com/WebAssembly/WASI/pull/870
github-actions[bot] added the label wasi on PR #12557.
ricochet updated PR #12557.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
For this,
append_via_streambelow, andsendwith TCP, the?here and the permission check all need to go into a createdFutureReader. Here the call toget_filefailing in?will trigger a trap as opposed to an error code, but the file-not-writable case is handled just fine here. In TCP down below the two?present there need to be funneled into a returnedFutureReader, however.
alexcrichton created PR review comment:
This is applicable to
read_directorybelow too a bit. One thing I might recommend is usingand_thenor similar combinators to avoid using?in the function bodies and that should make it a bit easier to see the flow of things.Another option would be to remove the
trappableoption for these imports in thebindgen!configuration. That'll remove thewasmtime::Resultlayer of the return value and force us to implement this in a non-trapping fashion.
ricochet updated PR #12557.
ricochet updated PR #12557.
ricochet updated PR #12557.
ricochet has marked PR #12557 as ready for review.
ricochet requested wasmtime-wasi-reviewers for a review on PR #12557.
ricochet requested wasmtime-core-reviewers for a review on PR #12557.
ricochet requested pchickey for a review on PR #12557.
ricochet requested wasmtime-default-reviewers for a review on PR #12557.
alexcrichton submitted PR review.
alexcrichton added PR #12557 chore: bump to wasi 0.3.0-rc-2026-02-09 to the merge queue.
alexcrichton merged PR #12557.
alexcrichton removed PR #12557 chore: bump to wasi 0.3.0-rc-2026-02-09 from the merge queue.
Last updated: Feb 24 2026 at 04:36 UTC