Stream: git-wasmtime

Topic: wasmtime / PR #12555 Use low-level ELF-parsing APIs in `C...

Wasmtime GitHub notifications bot (Feb 09 2026 at 23:29):

fitzgen opened PR #12555 from fitzgen:low-level-elf-parsing-in-code-memory-new to bytecodealliance:main:

These avoid allocations and should generally be faster because they avoid unnecessary work.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 09 2026 at 23:29):

fitzgen requested dicej for a review on PR #12555.

Wasmtime GitHub notifications bot (Feb 09 2026 at 23:29):

fitzgen requested wasmtime-core-reviewers for a review on PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 00:07):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2026 at 00:07):

alexcrichton created PR review comment:

We generate a pretty limited set of sections, so would it be possible to invert this and assert! that the type is in an allow-list of types? I say because I have no idea what sections create relocations, and while I'm sure what's here is a subset I've no idea if it's exhaustive

Wasmtime GitHub notifications bot (Feb 10 2026 at 00:07):

alexcrichton created PR review comment:

Mind leaving this as-was? That way there's no need to possibly conditionally improt ExceptionTable and we can avoid #[cfg]-on-use

Wasmtime GitHub notifications bot (Feb 10 2026 at 00:07):

alexcrichton created PR review comment:

I'm not entirely sure what's going on in CI, but it may be related to the lack of subtraction here? Even with that though I would assume that everything in theory should work out... So... I'm not sure what's happening?

Wasmtime GitHub notifications bot (Feb 10 2026 at 04:36):

github-actions[bot] added the label wasmtime:api on PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 17:03):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2026 at 17:03):

fitzgen created PR review comment:

bUt iT iS 150% mOrE lInEs oF CoDE!!!11!!2!

(heh, didn't think about the imports)

Wasmtime GitHub notifications bot (Feb 10 2026 at 17:05):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2026 at 17:05):

fitzgen created PR review comment:

We can do that, I just didn't want to change our existing behavior of logging+ignoring unknown sections. But I definitely prefer not accepting unknown stuff.

Wasmtime GitHub notifications bot (Feb 10 2026 at 19:31):

fitzgen updated PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 19:31):

fitzgen requested alexcrichton for a review on PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 19:54):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2026 at 19:55):

alexcrichton added PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new to the merge queue

Wasmtime GitHub notifications bot (Feb 10 2026 at 20:10):

github-merge-queue[bot] removed PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new from the merge queue

Wasmtime GitHub notifications bot (Feb 10 2026 at 20:10):

fitzgen added PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new to the merge queue

Wasmtime GitHub notifications bot (Feb 10 2026 at 20:10):

fitzgen removed PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new from the merge queue

Wasmtime GitHub notifications bot (Feb 10 2026 at 20:13):

fitzgen updated PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 20:13):

fitzgen has enabled auto merge for PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 20:25):

fitzgen added PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new to the merge queue

Wasmtime GitHub notifications bot (Feb 10 2026 at 20:53):

github-merge-queue[bot] removed PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new from the merge queue

Wasmtime GitHub notifications bot (Feb 10 2026 at 22:21):

fitzgen updated PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 22:21):

fitzgen has enabled auto merge for PR #12555.

Wasmtime GitHub notifications bot (Feb 10 2026 at 22:34):

fitzgen added PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new to the merge queue

Wasmtime GitHub notifications bot (Feb 10 2026 at 22:50):

github-merge-queue[bot] removed PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new from the merge queue

Wasmtime GitHub notifications bot (Feb 11 2026 at 16:21):

fitzgen updated PR #12555.

Wasmtime GitHub notifications bot (Feb 11 2026 at 16:21):

fitzgen has enabled auto merge for PR #12555.

Wasmtime GitHub notifications bot (Feb 11 2026 at 18:10):

fitzgen updated PR #12555.

Wasmtime GitHub notifications bot (Feb 11 2026 at 18:24):

fitzgen added PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new to the merge queue

Wasmtime GitHub notifications bot (Feb 11 2026 at 19:01):

fitzgen merged PR #12555.

Wasmtime GitHub notifications bot (Feb 11 2026 at 19:01):

fitzgen removed PR #12555 Use low-level ELF-parsing APIs in CodeMemory::new from the merge queue

Last updated: Feb 24 2026 at 04:36 UTC