wasmtime / PR #12537 Handle OOM in `Linker::func_wrap` · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #12537 Handle OOM in `Linker::func_wrap`

Wasmtime GitHub notifications bot (Feb 05 2026 at 21:26):

fitzgen opened PR #12537 from fitzgen:handle-oom-in-linker-func-wrap to bytecodealliance:main:

Part of https://github.com/bytecodealliance/wasmtime/issues/12069

Depends on

https://github.com/bytecodealliance/wasmtime/pull/12536

https://github.com/bytecodealliance/wasmtime/pull/12535

https://github.com/bytecodealliance/wasmtime/pull/12534

Wasmtime GitHub notifications bot (Feb 05 2026 at 21:26):

fitzgen requested wasmtime-core-reviewers for a review on PR #12537.

Wasmtime GitHub notifications bot (Feb 05 2026 at 21:26):

fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12537.

Wasmtime GitHub notifications bot (Feb 05 2026 at 21:26):

fitzgen requested alexcrichton for a review on PR #12537.

Wasmtime GitHub notifications bot (Feb 05 2026 at 21:26):

fitzgen requested wasmtime-default-reviewers for a review on PR #12537.

Wasmtime GitHub notifications bot (Feb 05 2026 at 21:35):

fitzgen updated PR #12537.

Wasmtime GitHub notifications bot (Feb 05 2026 at 22:49):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 05 2026 at 22:49):

alexcrichton created PR review comment:

We should keep an eye on the amount of times this is hand-written -- it may end up being the case that it'd be best to write a #[derive] for this

Wasmtime GitHub notifications bot (Feb 05 2026 at 22:49):

alexcrichton created PR review comment:

This'll need replicating below as well, at which point it might make sense to go ahead and propagate the Result up one more layer

Wasmtime GitHub notifications bot (Feb 05 2026 at 22:49):

alexcrichton created PR review comment:

This is sort of tricky b/c we don't handle OOM failures here and it's non-obvious to test as well.

Perhaps just a // TODO for now? I don't think we have try_format yet nor try_to_string (or something similarly named) and no need to block this PR on that.

Wasmtime GitHub notifications bot (Feb 05 2026 at 23:49):

github-actions[bot] added the label wasmtime:api on PR #12537.

Wasmtime GitHub notifications bot (Feb 05 2026 at 23:49):

github-actions[bot] added the label fuzzing on PR #12537.

Wasmtime GitHub notifications bot (Feb 05 2026 at 23:49):

github-actions[bot] commented on PR #12537:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 06 2026 at 18:43):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Feb 06 2026 at 18:43):

fitzgen created PR review comment:

Our bail!(...) macro will actually handle OOM during formatting, so I tweaked things here such that we never allocate Strings that we will then feed into a bail!(...) format string, and instead just directly reference stuff in the bail!