Stream: git-wasmtime

Topic: wasmtime / PR #12536 Add a reusable `StringPool` for inte...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 21:18):

fitzgen opened PR #12536 from fitzgen:string-pool to bytecodealliance:main:

And make sure it handles allocation failure.

Depends on https://github.com/bytecodealliance/wasmtime/pull/12534 and https://github.com/bytecodealliance/wasmtime/pull/12535

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 21:18):

fitzgen requested alexcrichton for a review on PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 21:18):

fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 21:19):

fitzgen requested wasmtime-core-reviewers for a review on PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 21:19):

fitzgen requested wasmtime-default-reviewers for a review on PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 21:25):

fitzgen updated PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 21:32):

fitzgen updated PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 22:50):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 22:50):

alexcrichton created PR review comment:

Perhaps Box<str> instead of String to further emphasize the lack of reallocation + mutation?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 22:50):

alexcrichton created PR review comment:

This can be just Result instead of core::result::Result I think?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 22:50):

alexcrichton created PR review comment:

Given the self-borrowing nature here, this I think would be a good use case for ManuallyDrop and the destructor documents-via-code that strings is destroyed after map

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 23:49):

github-actions[bot] added the label fuzzing on PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 23:49):

github-actions[bot] added the label wasmtime:api on PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 05 2026 at 23:49):

github-actions[bot] commented on PR #12536:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2026 at 18:19):

fitzgen updated PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2026 at 18:19):

fitzgen has enabled auto merge for PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2026 at 18:21):

fitzgen updated PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2026 at 18:34):

fitzgen added PR #12536 Add a reusable StringPool for interning strings to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2026 at 18:58):

fitzgen merged PR #12536.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 06 2026 at 18:58):

fitzgen removed PR #12536 Add a reusable StringPool for interning strings from the merge queue.

Last updated: Feb 24 2026 at 04:36 UTC