fitzgen opened PR #12535 from fitzgen:fallible-alloc-only-hash-map to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested alexcrichton for a review on PR #12535.
fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12535.
fitzgen requested wasmtime-core-reviewers for a review on PR #12535.
fitzgen requested wasmtime-default-reviewers for a review on PR #12535.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Somewhat unrealted question here: is
saturating_*worth it to use here? I'd expect that the codegen for that would be pretty bad, but I'm not sure if it matters too too much per se
fitzgen submitted PR review.
fitzgen created PR review comment:
Just want to make sure that we don't wrap around and make it look like a small allocation failed when it was really a big one. Don't think it matters too much, but I also don't think these paths are hot enough to prefer things that can get better codegen over being as precise as we can be.
fitzgen has enabled auto merge for PR #12535.
fitzgen added PR #12535 Add a fallible-allocation-only version of HashMap to the merge queue
github-merge-queue[bot] removed PR #12535 Add a fallible-allocation-only version of HashMap from the merge queue
github-actions[bot] added the label fuzzing on PR #12535.
github-actions[bot] commented on PR #12535:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen updated PR #12535.
fitzgen has enabled auto merge for PR #12535.
fitzgen added PR #12535 Add a fallible-allocation-only version of HashMap to the merge queue
fitzgen merged PR #12535.
fitzgen removed PR #12535 Add a fallible-allocation-only version of HashMap from the merge queue
Last updated: Feb 24 2026 at 04:36 UTC