Wasmtime GitHub notifications bot (Feb 05 2026 at 21:16): Wasmtime GitHub notifications bot (Feb 05 2026 at 21:16):fitzgen opened PR #12534 from fitzgen:fallible-alloc-only-string to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:16):fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12534.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:16):fitzgen requested alexcrichton for a review on PR #12534.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:16):fitzgen requested wasmtime-core-reviewers for a review on PR #12534.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:19):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:19):alexcrichton created PR review comment:
Mind adding
s.push_str("...")here too?Also, out of curiosity, there's no need to have all these tests be separate is there? They could all be the same test right? (not that they necessarily should be, just wanted to confirm)
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:22):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:22):fitzgen created PR review comment:
Mind adding
s.push_str("...")here too?Good catch
Also, out of curiosity, there's no need to have all these tests be separate is there? They could all be the same test right? (not that they necessarily should be, just wanted to confirm)
Just that it is nice to test things in isolation as much as possible so that debugging failures is easier, and you don't have to wade through unrelated stuff/logs/etc.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:29):fitzgen updated PR #12534.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:29):fitzgen has enabled auto merge for PR #12534.
Wasmtime GitHub notifications bot (Feb 05 2026 at 21:42):fitzgen added PR #12534 Add a fallible-allocation-only version of String to the merge queue
Wasmtime GitHub notifications bot (Feb 05 2026 at 22:18):fitzgen merged PR #12534.
Wasmtime GitHub notifications bot (Feb 05 2026 at 22:18):fitzgen removed PR #12534 Add a fallible-allocation-only version of String from the merge queue
Last updated: Feb 24 2026 at 04:36 UTC