fitzgen opened PR #12533 from fitzgen:gc-fuzzer-clean-ups to bytecodealliance:main:
This commit cleans up a few random things about the
gc_opsfuzzing mutator, notably:
- The macro to define
GcOpand many of its methods is refactored to be more extensible going forward (e.g. all of GC opfixupis now macro-generated, instead of having special-cases for typed struct ops, and we could probably also move encoding into the macro as a follow up PR).- Furthermore, the macro is also a
for_each_*-style macro now, which lets us define the GC ops once and then use the macro multiple times to define different things, rather than being forced to put everything we want to generate into one macro RHS. This should make things a bit easier to read and edit and plays nicer with LSP.- A bunch of GC op filtering that was logically part of fixing up an instruction is now actually part of
GcOp::fixup. Also a redundantop.fixup()call was removed,GcOp::fixuptakes&selfinstead of&mut selfsince it returns a newGcOpnow instead of mutatintselfin place, etc...- A few other small things here and there.
+cc @khagankhan @eeide
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12533.
fitzgen requested alexcrichton for a review on PR #12533.
fitzgen updated PR #12533.
khagankhan commented on PR #12533:
Thank you so much! Looks nice!
alexcrichton submitted PR review:
I'm rubber-stamping this since y'all two are the experts on this fuzzer and I figure it doesn't need super close review, but @fitzgen if you want me to take a look at anything in particular lemme know
fitzgen added PR #12533 Clean up gc_ops fuzzing mutator to the merge queue.
fitzgen merged PR #12533.
fitzgen removed PR #12533 Clean up gc_ops fuzzing mutator from the merge queue.
Last updated: Feb 24 2026 at 04:36 UTC