sashass1315 opened PR #12514 from sashass1315:cleanup/gc-trap-sentinel-dead-arm to bytecodealliance:main:
Removed a dead @get gc u64 arm in BuiltinFunctionIndex::trap_sentinel that referenced a non-existent gc builtin and could mislead readers about the actual GC trapping contract. The atomics-related comment in the same block also contained a typo that made the intent harder to read.
sashass1315 requested dicej for a review on PR #12514.
sashass1315 requested wasmtime-core-reviewers for a review on PR #12514.
sashass1315 edited PR #12514:
Removed a dead
@getgc u64 arm in BuiltinFunctionIndex::trap_sentinel that referenced a non-existent gc builtin and could mislead readers about the actual GC trapping contract. The atomics-related comment in the same block also contained a typo that made the intent harder to read.
alexcrichton submitted PR review:
Thanks!
alexcrichton added PR #12514 chore: remove dead gc trap sentinel arm to the merge queue.
github-merge-queue[bot] removed PR #12514 chore: remove dead gc trap sentinel arm from the merge queue.
alexcrichton added PR #12514 chore: remove dead gc trap sentinel arm to the merge queue.
alexcrichton merged PR #12514.
alexcrichton removed PR #12514 chore: remove dead gc trap sentinel arm from the merge queue.
Last updated: Feb 24 2026 at 04:36 UTC