Stream: git-wasmtime

Topic: wasmtime / PR #12514 chore: remove dead gc trap sentinel arm


view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 11:59):

sashass1315 opened PR #12514 from sashass1315:cleanup/gc-trap-sentinel-dead-arm to bytecodealliance:main:

Removed a dead @get gc u64 arm in BuiltinFunctionIndex::trap_sentinel that referenced a non-existent gc builtin and could mislead readers about the actual GC trapping contract. The atomics-related comment in the same block also contained a typo that made the intent harder to read.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 11:59):

sashass1315 requested dicej for a review on PR #12514.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 11:59):

sashass1315 requested wasmtime-core-reviewers for a review on PR #12514.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 12:00):

sashass1315 edited PR #12514:

Removed a dead @get gc u64 arm in BuiltinFunctionIndex::trap_sentinel that referenced a non-existent gc builtin and could mislead readers about the actual GC trapping contract. The atomics-related comment in the same block also contained a typo that made the intent harder to read.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 15:27):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 15:27):

alexcrichton added PR #12514 chore: remove dead gc trap sentinel arm to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 15:54):

github-merge-queue[bot] removed PR #12514 chore: remove dead gc trap sentinel arm from the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 16:25):

alexcrichton added PR #12514 chore: remove dead gc trap sentinel arm to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 16:49):

alexcrichton merged PR #12514.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 16:49):

alexcrichton removed PR #12514 chore: remove dead gc trap sentinel arm from the merge queue.


Last updated: Feb 24 2026 at 04:36 UTC