alexcrichton requested fitzgen for a review on PR #12508.
alexcrichton opened PR #12508 from alexcrichton:merge-some-prs to bytecodealliance:main:
Merging together #12500 and #12505 of a sorts.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-core-reviewers for a review on PR #12508.
fitzgen created PR review comment:
debug_assert_eq!(shared_type_indices.len(), shared_type_indices.capacity()); shared_type_indices .into_boxed_slice() .expect("capacity should be exact")
fitzgen submitted PR review:
Thanks!
github-actions[bot] added the label wasmtime:api on PR #12508.
alexcrichton updated PR #12508.
alexcrichton commented on PR #12508:
TIL
Vec::with_capacityis not an exact-fit allocation, it reserves at least that capacity
alexcrichton has enabled auto merge for PR #12508.
alexcrichton added PR #12508 Use fallible collection helpers in TypeRegistry to the merge queue
alexcrichton merged PR #12508.
alexcrichton removed PR #12508 Use fallible collection helpers in TypeRegistry from the merge queue
Last updated: Feb 24 2026 at 04:36 UTC