Wasmtime GitHub notifications bot (Feb 03 2026 at 16:49): Wasmtime GitHub notifications bot (Feb 03 2026 at 16:49):cfallin opened PR #12504 from cfallin:fix-12503 to bytecodealliance:main:
Fixes #12503.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 03 2026 at 16:49):cfallin requested wasmtime-compiler-reviewers for a review on PR #12504.
Wasmtime GitHub notifications bot (Feb 03 2026 at 16:49):cfallin requested alexcrichton for a review on PR #12504.
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:05):jameshu15869 submitted PR review.
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:05):jameshu15869 created PR review comment:
Very minor but I believe #12503 mentioned this was at least seen on x86 and arm64, likely other architectures too. Should those be added here?
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:06):jameshu15869 submitted PR review.
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:06):jameshu15869 created PR review comment:
We didn't add this configuration to our test files in the original PR (#12135) - would it help to add those in?
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:07):jameshu15869 edited PR review comment.
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:26):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:26):cfallin created PR review comment:
That shouldn't matter here since this is a mid-end issue -- all that matters is that we hit the optimization rule in question, and since the particular regression we're testing to avoid is a verifier error, any platform that hits the issue is sufficient.
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:29):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:29):cfallin created PR review comment:
Ah, it looks like the verifier is actually on by default in tests -- this line is redundant (removing it still hits the regression without the fix).
Wasmtime GitHub notifications bot (Feb 03 2026 at 17:32):cfallin updated PR #12504.
Wasmtime GitHub notifications bot (Feb 03 2026 at 18:25):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Feb 03 2026 at 18:26):fitzgen added PR #12504 Cranelift: mid-end: fix constant types in some icmp/select rules. to the merge queue
Wasmtime GitHub notifications bot (Feb 03 2026 at 18:48):fitzgen merged PR #12504.
Wasmtime GitHub notifications bot (Feb 03 2026 at 18:48):fitzgen removed PR #12504 Cranelift: mid-end: fix constant types in some icmp/select rules. from the merge queue
Last updated: Feb 24 2026 at 04:36 UTC