pchickey edited PR #12496.
pchickey updated PR #12496.
github-actions[bot] added the label wasmtime:api on PR #12496.
alexcrichton submitted PR review:
Personally I'm not overly thrilled about extending the
Lift/Lower/etc traits given the complexity of testing them and the sheer breadth of impls required, but this is overall relatively minor in terms of complexity. Before landing mind also expanding the PR description with some rationale for the expected use cases?Bikeshedding wise I might say
to_valinstead ofas_valsince "as" implies "cheap" typically and this definitely isn't cheap. I'd also bikeshed the signature a bit to useStoreContextMut<T>rather thanimpl AsContextMutto avoid the extra indirection ofimpl Traitwhere possible.The
'staticbounds popping up on futures/streams is fine, those are only really practically usable with'statictypes anyway, so I don't think that'll be an issue. The specifics ofas_valfor futures/streams I think will want to be re-worked a bit too to avoid manually creating structs, but I can take a closer look once this is closer to landing.Similar to futures/streams I'll need to think a bit harder about the
try_as_resource_anymethod added here for resources. I forget exactly where we are on clone/copy/etc on those and how it affects what we document in terms of guarantees and whatnot.
pchickey updated PR #12496.
pchickey updated PR #12496.
pchickey updated PR #12496.
pchickey updated PR #12496.
pchickey updated PR #12496.
pchickey updated PR #12496.
pchickey updated PR #12496.
Last updated: Feb 24 2026 at 04:36 UTC