Stream: git-wasmtime

Topic: wasmtime / PR #12484 cranelift: improve debug value locat...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 06:02):

philipc opened PR #12484 from philipc:issue-11337 to bytecodealliance:main:

If a debug range started or ended on an instruction from a cold block, we omitted the entire range. Fix by skipping the instructions in the cold block to find the next valid offset.

Closes #11337

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 06:02):

philipc requested cfallin for a review on PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 06:02):

philipc requested wasmtime-compiler-reviewers for a review on PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 06:02):

philipc requested wasmtime-core-reviewers for a review on PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 06:02):

philipc requested dicej for a review on PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 06:07):

philipc updated PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 06:09):

philipc commented on PR #12484:

Before this change, the WASMTIME_LOG=cranelift_codegen::machinst::vcode=trace output for foo showed:

|BB|Inst    |IP         |VL0     |VL1      |VL2     |VL3      |VL4     |VL5     |VL6     |VL7     |VL8     |VL9     |VL10    |VL11    |VL12    |VL13    |VL14    |VL15    |VL16    |VL17    |VL18    |VL4294967294|
|--|--------|-----------|--------|---------|--------|---------|--------|--------|--------|--------|--------|--------|--------|--------|--------|--------|--------|--------|--------|--------|--------|------------|
|B0|Inst 0  |53         |    |   |    |    |    |   |    |    |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |       |
|  |Inst 1  |53         |v194|p2i|    |    |    |   |    |    |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |v192|p7i    |
|  |Inst 2  |60         |*   |p2i|v269|p13i|v196|   |    |    |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 3  |64         |*   |p2i|*   |p13i|*   |   |v268|p14i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 4  |68         |*   |p2i|*   |p13i|*   |   |*   |p14i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 5  |72         |*   |p2i|*   |p13i|*   |   |*   |p14i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 6  |76         |*   |p2i|*   |p13i|*   |   |*   |p14i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 7  |81         |*   |p2i|*   |p13i|*   |   |*   |p14i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 8  |83         |*   |   |*   |p13i|*   |   |*   |p14i|v265|p0i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 9  |88         |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |v264|p1i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 10 |88         |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |p1i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 11 |91         |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |p1i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p7i    |
|  |Inst 12 |98         |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |p1i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 13 |100        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |p1i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 14 |104        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |p1i|    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 15 |107        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 16 |111        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 17 |117        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 18 |121        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 19 |124        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|B1|Inst 20 |133        |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|B2|Inst 21 |4294967295 |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 22 |4294967295 |*   |   |*   |p13i|*   |   |*   |p14i|*   |   |*   |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |    |   |*   |p9i    |
|  |Inst 23 |4294967295 |*   |   |v255|p6i |v255|p6i|v255|p6i |v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|v255|p6i|*   |p12i   |
|  |Inst 24 |4294967295 |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|B3|Inst 25 |133        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 26 |137        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 27 |142        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 28 |145        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 29 |151        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 30 |155        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 31 |162        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 32 |164        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 33 |167        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |v248|p7i|*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 34 |171        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |v247|p7i|v234|   |v247|p7i|v234|   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 35 |174        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|B4|Inst 36 |180        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 37 |189        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|B5|Inst 38 |194        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |v240|   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 39 |203        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|B6|Inst 40 |203        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p12i   |
|  |Inst 41 |208        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |v246|p0i|*   |   |*   |   |*   |p12i   |
|  |Inst 42 |213        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |   |*   |p0i|*   |   |*   |   |*   |p12i   |
|  |Inst 43 |213        |*   |   |*   |    |*   |   |*   |    |*   |   |*   |   |*   |   |*   |   |
[message truncated]

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 07:51):

github-actions[bot] added the label cranelift on PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2026 at 07:51):

github-actions[bot] added the label cranelift:area:machinst on PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 19:42):

cfallin submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 19:42):

cfallin added PR #12484 cranelift: improve debug value locations around cold blocks to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 20:06):

cfallin merged PR #12484.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 04 2026 at 20:06):

cfallin removed PR #12484 cranelift: improve debug value locations around cold blocks from the merge queue.


Last updated: Feb 24 2026 at 04:36 UTC