Stream: git-wasmtime

Topic: wasmtime / PR #12479 fix: skip importing `std::path::Path...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 05:39):

HoKim98 requested fitzgen for a review on PR #12479.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 05:39):

HoKim98 requested wasmtime-core-reviewers for a review on PR #12479.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 05:39):

HoKim98 opened PR #12479 from ulagbulag:fix/skip-importing-path-regardless-of-cache-feature to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

This PR just skips importing std::path::Path on crates/wasmtime/src/config.rs regardless of cache feature.

Currently, only either cranelift and winit feature requires importing it. cache feature is now unrelated.

The only use-case is here below:

https://github.com/bytecodealliance/wasmtime/blob/fdd8ed9e44f1df296568b1845c18d072b5e56681/crates/wasmtime/src/config.rs#L2706-L2711

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 07:02):

github-actions[bot] added the label wasmtime:api on PR #12479.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 07:02):

github-actions[bot] added the label wasmtime:config on PR #12479.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 07:56):

github-actions[bot] commented on PR #12479:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 14:27):

alexcrichton commented on PR #12479:

Thanks! Could you add a check here with --features runtime,cache to help catch this in the future too?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 16:15):

HoKim98 requested wasmtime-default-reviewers for a review on PR #12479.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 16:15):

HoKim98 updated PR #12479.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 16:16):

HoKim98 commented on PR #12479:

Sure! Added the requested test case at the end.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 19:46):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 19:47):

alexcrichton added PR #12479 fix: skip importing std::path::Path regardless of cache feature to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 20:10):

alexcrichton merged PR #12479.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 30 2026 at 20:10):

alexcrichton removed PR #12479 fix: skip importing std::path::Path regardless of cache feature from the merge queue.


Last updated: Feb 24 2026 at 04:36 UTC