Stream: git-wasmtime

Topic: wasmtime / PR #12463 Fixes #12458

Wasmtime GitHub notifications bot (Jan 28 2026 at 19:58):

karthik-phl requested wasmtime-wasi-reviewers for a review on PR #12463.

Wasmtime GitHub notifications bot (Jan 28 2026 at 19:58):

karthik-phl opened PR #12463 from karthik-phl:fix_issue_12458 to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

• Fixes #12458 and added test to validate
• This fix is necessary so that the StreamProducer implementation for HostBodyStreamProvider handles 0-length frames correctly
  

Wasmtime GitHub notifications bot (Jan 29 2026 at 16:49):

alexcrichton created PR review comment:

This looks like it should also be checking the size of the frame received because if it's a nonzero-sized-frame but the body has ended it seems like we'd still want to yield/copy that frame and then only on the next poll sever the stream when is_end_stream is true

Wasmtime GitHub notifications bot (Jan 29 2026 at 16:49):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 29 2026 at 19:03):

karthik-phl updated PR #12463.

Wasmtime GitHub notifications bot (Jan 29 2026 at 19:06):

karthik-phl submitted PR review.

Wasmtime GitHub notifications bot (Jan 29 2026 at 19:06):

karthik-phl created PR review comment:

Fair point. I have updated the check and added an extra test. Thanks.

Wasmtime GitHub notifications bot (Jan 29 2026 at 21:59):

karthik-phl requested alexcrichton for a review on PR #12463.

Wasmtime GitHub notifications bot (Jan 30 2026 at 19:44):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jan 30 2026 at 19:44):

alexcrichton added PR #12463 Fixes #12458 to the merge queue.

Wasmtime GitHub notifications bot (Jan 30 2026 at 20:09):

alexcrichton merged PR #12463.

Wasmtime GitHub notifications bot (Jan 30 2026 at 20:09):

alexcrichton removed PR #12463 Fixes #12458 from the merge queue.

Last updated: Feb 24 2026 at 04:36 UTC