Stream: git-wasmtime

Topic: wasmtime / PR #1246 Refactor SIMD implementation

Wasmtime GitHub notifications bot (Mar 06 2020 at 18:27):

abrown opened PR #1246 from refactor-simd to master:

Before adding the remaining SIMD instructions, I thought it would be good to clean up the current implementation. I have tried to be very careful to avoid any change to behavior when renaming/moving things around. The changes are:

• To reduce compile times (along the lines of #1168), I separated out some instructions and legalizations into their own define methods
• For filetest clarity, I renamed all x86 SIMD filetests with a simd- prefix and removed the %test_ prefix of the individual test functions (I've noticed that Cranelift chops off the ends of those functions so the test_ prefix can hide which test is failing)

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:21):

peterhuene requested bnjbvr for a review on PR #1246.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:21):

peterhuene requested bnjbvr, and sunfishcode for a review on PR #1246.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:21):

peterhuene requested peterhuene, bnjbvr, and sunfishcode for a review on PR #1246.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:23):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:51):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:51):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:51):

sunfishcode created PR Review Comment:

Please keep comments wrapped at 100 columns or so (which is the rustfmt column limit, except it doesn't automatically split up comments).

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:51):

sunfishcode created PR Review Comment:

Why is this line being removed?

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:58):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:58):

sunfishcode created PR Review Comment:

As we discussed offline, this is a run test, so it naturally uses the host as the target.

Wasmtime GitHub notifications bot (Mar 06 2020 at 21:58):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 06 2020 at 22:22):

abrown updated PR #1246 from refactor-simd to master:

Before adding the remaining SIMD instructions, I thought it would be good to clean up the current implementation. I have tried to be very careful to avoid any change to behavior when renaming/moving things around. The changes are:

• To reduce compile times (along the lines of #1168), I separated out some instructions and legalizations into their own define methods
• For filetest clarity, I renamed all x86 SIMD filetests with a simd- prefix and removed the %test_ prefix of the individual test functions (I've noticed that Cranelift chops off the ends of those functions so the test_ prefix can hide which test is failing)

Wasmtime GitHub notifications bot (Mar 06 2020 at 22:57):

abrown merged PR #1246.

Last updated: Dec 23 2024 at 12:05 UTC