fitzgen opened PR #12453 from fitzgen:add-fallible-alloc-methods-to-secondary-map to bytecodealliance:main:
We will use these in the fallible-allocations-only version of this type that we will add to Wasmtime.
In the cases where there wasn't already an infallible version of the method (e.g.
try_insert, because we have just used mutable indexing up till now instead ofinsert) I still defined the infallible version, since it seemed weird to have one but not the other.Part of https://github.com/bytecodealliance/wasmtime/issues/12069
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested wasmtime-compiler-reviewers for a review on PR #12453.
fitzgen requested alexcrichton for a review on PR #12453.
fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12453.
fitzgen unassigned alexcrichton from PR #12453 Add some fallible allocation methods to cranelift_entity::SecondaryMap.
fitzgen requested cfallin for a review on PR #12453.
github-actions[bot] added the label cranelift on PR #12453.
github-actions[bot] added the label fuzzing on PR #12453.
github-actions[bot] commented on PR #12453:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
cfallin submitted PR review.
fitzgen added PR #12453 Add some fallible allocation methods to cranelift_entity::SecondaryMap to the merge queue
fitzgen merged PR #12453.
fitzgen removed PR #12453 Add some fallible allocation methods to cranelift_entity::SecondaryMap from the merge queue
Last updated: Jan 29 2026 at 13:25 UTC