Stream: git-wasmtime

Topic: wasmtime / PR #12450 Force callers to handle allocation f...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 18:08):

fitzgen requested alexcrichton for a review on PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 18:08):

fitzgen opened PR #12450 from fitzgen:slab-handle-oom to bytecodealliance:main:

Depends on https://github.com/bytecodealliance/wasmtime/pull/12449

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 18:08):

fitzgen requested wasmtime-core-reviewers for a review on PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 18:10):

fitzgen updated PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 19:27):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 19:28):

fitzgen added PR #12450 Force callers to handle allocation failure in Slab to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 19:29):

fitzgen removed PR #12450 Force callers to handle allocation failure in Slab from the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 20:17):

fitzgen updated PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 20:17):

fitzgen has enabled auto merge for PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 20:31):

fitzgen added PR #12450 Force callers to handle allocation failure in Slab to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 20:51):

github-merge-queue[bot] removed PR #12450 Force callers to handle allocation failure in Slab from the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 21:41):

fitzgen added PR #12450 Force callers to handle allocation failure in Slab to the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 21:46):

github-actions[bot] added the label wasmtime:api on PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 21:46):

github-actions[bot] added the label wasmtime:ref-types on PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 21:47):

github-actions[bot] commented on PR #12450:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 22:08):

fitzgen merged PR #12450.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2026 at 22:08):

fitzgen removed PR #12450 Force callers to handle allocation failure in Slab from the merge queue

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2026 at 16:55):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2026 at 16:55):

alexcrichton created PR review comment:

Thought on this: this might be best modeled as .unwrap_no_oom() (bikeshed the name) to statically assert that this only works on Result<T, OutOfMemory> and no other types of Result. This location itself is probably temporary and not worth the trait, but the idea of internally the collections delegate infallible methods to fallible methods might be a more permanent .unwrap()-lookalike and clearly demarcating that as "the only panic condition is OOM" might be nice

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2026 at 19:28):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2026 at 19:28):

fitzgen created PR review comment:

Just put up this PR for this: https://github.com/bytecodealliance/wasmtime/pull/12461


Last updated: Jan 29 2026 at 13:25 UTC