fitzgen requested alexcrichton for a review on PR #12450.
fitzgen opened PR #12450 from fitzgen:slab-handle-oom to bytecodealliance:main:
Depends on https://github.com/bytecodealliance/wasmtime/pull/12449
fitzgen requested wasmtime-core-reviewers for a review on PR #12450.
fitzgen updated PR #12450.
pchickey submitted PR review.
fitzgen added PR #12450 Force callers to handle allocation failure in Slab to the merge queue
fitzgen removed PR #12450 Force callers to handle allocation failure in Slab from the merge queue
fitzgen updated PR #12450.
fitzgen has enabled auto merge for PR #12450.
fitzgen added PR #12450 Force callers to handle allocation failure in Slab to the merge queue
github-merge-queue[bot] removed PR #12450 Force callers to handle allocation failure in Slab from the merge queue
fitzgen added PR #12450 Force callers to handle allocation failure in Slab to the merge queue
github-actions[bot] added the label wasmtime:api on PR #12450.
github-actions[bot] added the label wasmtime:ref-types on PR #12450.
github-actions[bot] commented on PR #12450:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen merged PR #12450.
fitzgen removed PR #12450 Force callers to handle allocation failure in Slab from the merge queue
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Thought on this: this might be best modeled as
.unwrap_no_oom()(bikeshed the name) to statically assert that this only works onResult<T, OutOfMemory>and no other types ofResult. This location itself is probably temporary and not worth the trait, but the idea of internally the collections delegate infallible methods to fallible methods might be a more permanent.unwrap()-lookalike and clearly demarcating that as "the only panic condition is OOM" might be nice
fitzgen submitted PR review.
fitzgen created PR review comment:
Just put up this PR for this: https://github.com/bytecodealliance/wasmtime/pull/12461
Last updated: Jan 29 2026 at 13:25 UTC