wasmtime / PR #1244 Add an opcode accessor to require tha... · git-wasmtime

clobber_all is a bit more pessimistic than we need for __tls_get_addr, which seems to really be has the architectural effects of an ABI-conforming call (callee-save registers are not clobbered)

Since you and @bjorn3 were both going for a clobbers_all* change this seems fine, but can I bug you for a comment here and below that this is a bit broader than should be necessary?

Wasmtime GitHub notifications bot (Mar 06 2020 at 17:32):

bjorn3 created PR Review Comment:

Callee-saved registers are clobbered for normal calls too currently. There is a fixme in spilling.rs for that.

Wasmtime GitHub notifications bot (Mar 06 2020 at 17:32):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 06 2020 at 17:48):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr updated PR #1244 from clobber_all_regs to master:

As seen in #1240. Also adds CI that would help catching build failures on arm64 / x86 only, or non-debug builds.

Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr requested iximeow for a review on PR #1244.

Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr created PR Review Comment:

I added a comment, please let me know what you think of it!

Wasmtime GitHub notifications bot (Mar 23 2020 at 03:20):

iximeow submitted PR Review.

Wasmtime GitHub notifications bot (Mar 23 2020 at 10:48):

bnjbvr updated PR #1244 from clobber_all_regs to master:

As seen in #1240. Also adds CI that would help catching build failures on arm64 / x86 only, or non-debug builds.

Wasmtime GitHub notifications bot (Mar 23 2020 at 11:19):

bnjbvr merged PR #1244.

Last updated: Oct 23 2024 at 20:03 UTC