Stream: git-wasmtime

Topic: wasmtime / PR #1244 Add an opcode accessor to require tha...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 14:41):

bnjbvr opened PR #1244 from clobber_all_regs to master:

As seen in #1240.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 14:41):

bnjbvr edited PR #1244 from clobber_all_regs to master:

As seen in #1240. Also adds CI that would help catching build failures on arm64 / x86 only, or non-debug builds.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 14:42):

bnjbvr requested alexcrichton, and iximeow for a review on PR #1244.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 14:42):

bnjbvr requested alexcrichton, and iximeow for a review on PR #1244.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 16:19):

bnjbvr updated PR #1244 from clobber_all_regs to master:

As seen in #1240. Also adds CI that would help catching build failures on arm64 / x86 only, or non-debug builds.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 17:28):

iximeow submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 17:28):

iximeow submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 17:28):

iximeow created PR Review Comment:

Oh! I just learned that I was passing --features wrong when I tried to do a build entirely in-tree. Very cool :)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 17:28):

iximeow created PR Review Comment:

clobber_all is a bit more pessimistic than we need for __tls_get_addr, which seems to really be has the architectural effects of an ABI-conforming call (callee-save registers are not clobbered)

Since you and @bjorn3 were both going for a clobbers_all* change this seems fine, but can I bug you for a comment here and below that this is a bit broader than should be necessary?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 17:32):

bjorn3 created PR Review Comment:

Callee-saved registers are clobbered for normal calls too currently. There is a fixme in spilling.rs for that.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 17:32):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 17:48):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr updated PR #1244 from clobber_all_regs to master:

As seen in #1240. Also adds CI that would help catching build failures on arm64 / x86 only, or non-debug builds.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr requested iximeow for a review on PR #1244.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2020 at 10:40):

bnjbvr created PR Review Comment:

I added a comment, please let me know what you think of it!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2020 at 03:20):

iximeow submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2020 at 10:48):

bnjbvr updated PR #1244 from clobber_all_regs to master:

As seen in #1240. Also adds CI that would help catching build failures on arm64 / x86 only, or non-debug builds.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2020 at 11:19):

bnjbvr merged PR #1244.


Last updated: Dec 23 2024 at 12:05 UTC