Stream: git-wasmtime

Topic: wasmtime / PR #12431 perf(wasi): avoid extra allocations ...

Wasmtime GitHub notifications bot (Jan 26 2026 at 07:55):

MoNyAvA opened PR #12431 from MoNyAvA:perf/wasi-inherit-env-args to bytecodealliance:main:

WasiCtxBuilder::inherit_env and inherit_args were doing redundant work: they first collected std::env::vars() / std::env::args() into a Vec, and then envs/args cloned every string again via to_owned(). This caused two allocations per environment variable or argument plus an extra temporary vector, without any semantic benefit

Wasmtime GitHub notifications bot (Jan 26 2026 at 07:55):

MoNyAvA requested wasmtime-wasi-reviewers for a review on PR #12431.

Wasmtime GitHub notifications bot (Jan 26 2026 at 07:55):

MoNyAvA edited PR #12431:

WasiCtxBuilder::inherit_env and inherit_args were doing redundant work: they first collected std::env::vars() / std::env::args() into a Vec, and then envs/args cloned every string again via to_owned(). This caused two allocations per environment variable or argument plus an extra temporary vector, without any benefit

Wasmtime GitHub notifications bot (Jan 26 2026 at 09:51):

github-actions[bot] added the label wasi on PR #12431.

Wasmtime GitHub notifications bot (Jan 26 2026 at 13:25):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jan 26 2026 at 13:25):

alexcrichton added PR #12431 perf(wasi): avoid extra allocations in inherit_env/args to the merge queue.

Wasmtime GitHub notifications bot (Jan 26 2026 at 13:49):

alexcrichton merged PR #12431.

Wasmtime GitHub notifications bot (Jan 26 2026 at 13:49):

alexcrichton removed PR #12431 perf(wasi): avoid extra allocations in inherit_env/args from the merge queue.

Last updated: Jan 29 2026 at 13:25 UTC