fitzgen opened PR #12414 from fitzgen:remove-memory-tys-param-from-vm-instance-new to bytecodealliance:main:
We already have this information in the
InstanceAllocationRequest, and by avoiding a parameter we can never accidentally pass the wrong memory types.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested alexcrichton for a review on PR #12414.
fitzgen requested wasmtime-core-reviewers for a review on PR #12414.
alexcrichton submitted PR review.
fitzgen has enabled auto merge for PR #12414.
fitzgen added PR #12414 Remove unnecessary memory_tys param from vm::Instance::new to the merge queue
fitzgen merged PR #12414.
fitzgen removed PR #12414 Remove unnecessary memory_tys param from vm::Instance::new from the merge queue
Last updated: Jan 29 2026 at 13:25 UTC