Wasmtime GitHub notifications bot (Jan 23 2026 at 19:05): Wasmtime GitHub notifications bot (Jan 23 2026 at 19:05):0xbe7a edited PR #12410.
Wasmtime GitHub notifications bot (Jan 23 2026 at 19:18):0xbe7a edited PR #12410:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->There is a typo in the x86_64_v3 flag:
x84_64_v3— notex84vsx86.Also these flags should be normalised to use underscores or hyphens consistently, not a mix of hyphens and underscores.
Wasmtime GitHub notifications bot (Jan 23 2026 at 20:02):alexcrichton submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Jan 23 2026 at 20:02):alexcrichton added PR #12410 cranelift: fix x86_64_v3 flag and normalise all generic microarchitecture flags to the merge queue.
Wasmtime GitHub notifications bot (Jan 23 2026 at 20:37):alexcrichton merged PR #12410.
Wasmtime GitHub notifications bot (Jan 23 2026 at 20:37):alexcrichton removed PR #12410 cranelift: fix x86_64_v3 flag and normalise all generic microarchitecture flags from the merge queue.
Wasmtime GitHub notifications bot (Mar 16 2026 at 16:40):bjorn3 commented on PR #12410:
Also these flags should be normalised to use underscores or hyphens consistently, not a mix of hyphens and underscores.
This breaks cg_clif. LLVM uses x86-64 as target cpu name, so that is what Cranelift needs to accept too.
Wasmtime GitHub notifications bot (Mar 16 2026 at 16:40):bjorn3 edited a comment on PR #12410:
Also these flags should be normalised to use underscores or hyphens consistently, not a mix of hyphens and underscores.
This breaks cg_clif. LLVM uses x86-64 as target cpu name, so that is what Cranelift needs to accept too. https://github.com/rust-lang/rustc_codegen_cranelift/actions/runs/23154591265/job/67265690144
Wasmtime GitHub notifications bot (Mar 16 2026 at 16:42):bjorn3 edited a comment on PR #12410:
Also these flags should be normalised to use underscores or hyphens consistently, not a mix of hyphens and underscores.
This breaks cg_clif. LLVM uses x86-64 as target cpu name, so that is what Cranelift needs to accept too. https://github.com/rust-lang/rustc_codegen_cranelift/actions/runs/23154591265/job/67265690144 FWIW several other target cpus Cranelift accept still use hyphens, so this didn't even make it more consistent. All presets previously used hyphens.
Wasmtime GitHub notifications bot (Mar 16 2026 at 16:43):bjorn3 edited a comment on PR #12410:
Also these flags should be normalised to use underscores or hyphens consistently, not a mix of hyphens and underscores.
This breaks cg_clif. LLVM uses x86-64 as target cpu name, so that is what Cranelift needs to accept too. https://github.com/rust-lang/rustc_codegen_cranelift/actions/runs/23154591265/job/67265690144 FWIW several other target cpus Cranelift accept still use hyphens, so this didn't even make it more consistent. All presets previously used hyphens.
Last updated: Mar 23 2026 at 18:16 UTC