Stream: git-wasmtime

Topic: wasmtime / PR #1241 Add lldb smoke test

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2020 at 22:23):

yurydelendik opened PR #1241 from test-dwarf-lldb to master:

The test runs LLDB in batch mode and filecheck the output. It checks if breakpoint was found in the JIT code and specific variable value in the frame is set.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2020 at 22:49):

yurydelendik updated PR #1241 from test-dwarf-lldb to master:

The test runs LLDB in batch mode and filecheck the output. It checks if breakpoint was found in the JIT code and specific variable value in the frame is set.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2020 at 23:15):

yurydelendik updated PR #1241 from test-dwarf-lldb to master:

The test runs LLDB in batch mode and filecheck the output. It checks if breakpoint was found in the JIT code and specific variable value in the frame is set.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2020 at 23:18):

yurydelendik updated PR #1241 from test-dwarf-lldb to master:

The test runs LLDB in batch mode and filecheck the output. It checks if breakpoint was found in the JIT code and specific variable value in the frame is set.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 14:15):

yurydelendik updated PR #1241 from test-dwarf-lldb to master:

The test runs LLDB in batch mode and filecheck the output. It checks if breakpoint was found in the JIT code and specific variable value in the frame is set.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 15:10):

yurydelendik updated PR #1241 from test-dwarf-lldb to master:

The test runs LLDB in batch mode and filecheck the output. It checks if breakpoint was found in the JIT code and specific variable value in the frame is set.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:35):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:35):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:35):

alexcrichton created PR Review Comment:

If the Command type is created directly I think the to_str() conversion and the lldb_args vec can both be elided in favor of just calling the methods on Command to append arguments.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:35):

alexcrichton created PR Review Comment:

I might recommend printing out the debug version of the Command here since it prints out the arguments as well in addition to the path to lldb.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 23:31):

yurydelendik updated PR #1241 from test-dwarf-lldb to master:

The test runs LLDB in batch mode and filecheck the output. It checks if breakpoint was found in the JIT code and specific variable value in the frame is set.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2020 at 13:06):

yurydelendik merged PR #1241.

Last updated: Nov 22 2024 at 17:03 UTC